Re: [Qemu-devel] [PATCH v5 16/17] target/m68k: add the Interrupt Stack Pointer

2018-01-02 Thread Laurent Vivier
Le 02/01/2018 à 18:13, Richard Henderson a écrit : > On 01/01/2018 05:10 PM, Laurent Vivier wrote: >> env->sr = tmp; >> +m68k_switch_sp(env); > > I would much prefer a cpu_m68k_set_sr here, akin to cpu_m68k_set_ccr. Yes, it's a good idea, I also use several times helper_s

Re: [Qemu-devel] [PATCH v5 16/17] target/m68k: add the Interrupt Stack Pointer

2018-01-02 Thread Richard Henderson
On 01/01/2018 05:10 PM, Laurent Vivier wrote: > env->sr = tmp; > +m68k_switch_sp(env); I would much prefer a cpu_m68k_set_sr here, akin to cpu_m68k_set_ccr. r~

[Qemu-devel] [PATCH v5 16/17] target/m68k: add the Interrupt Stack Pointer

2018-01-01 Thread Laurent Vivier
Add the third stack pointer, the Interrupt Stack Pointer (ISP) (680x0 only). This stack will be needed in softmmu mode. Update movec to set/get the value of the three stacks. Signed-off-by: Laurent Vivier --- target/m68k/cpu.c | 3 ++ target/m68k/cpu.h | 70