Re: [Qemu-devel] [PATCH v5 13/20] hw/acpi/aml-build: Add ToUUID macro

2015-05-04 Thread Igor Mammedov
On Mon, 04 May 2015 17:30:20 +0800 Shannon Zhao wrote: > > > On 2015/5/4 17:22, Igor Mammedov wrote: > > On Wed, 29 Apr 2015 21:41:39 +0800 > > Shannon Zhao wrote: > > > >> > >> > >> On 2015/4/28 17:48, Shannon Zhao wrote: > >>> On 2015/4/28 17:35, Igor Mammedov wrote: > On Tue, 28 Apr 2

Re: [Qemu-devel] [PATCH v5 13/20] hw/acpi/aml-build: Add ToUUID macro

2015-05-04 Thread Shannon Zhao
On 2015/5/4 17:22, Igor Mammedov wrote: > On Wed, 29 Apr 2015 21:41:39 +0800 > Shannon Zhao wrote: > >> >> >> On 2015/4/28 17:48, Shannon Zhao wrote: >>> On 2015/4/28 17:35, Igor Mammedov wrote: On Tue, 28 Apr 2015 16:52:19 +0800 Shannon Zhao wrote: > On 2015/4/28 16:15, Igo

Re: [Qemu-devel] [PATCH v5 13/20] hw/acpi/aml-build: Add ToUUID macro

2015-05-04 Thread Igor Mammedov
On Wed, 29 Apr 2015 21:41:39 +0800 Shannon Zhao wrote: > > > On 2015/4/28 17:48, Shannon Zhao wrote: > > On 2015/4/28 17:35, Igor Mammedov wrote: > >> On Tue, 28 Apr 2015 16:52:19 +0800 > >> Shannon Zhao wrote: > >> > >>> On 2015/4/28 16:15, Igor Mammedov wrote: > >> btw: > whole

Re: [Qemu-devel] [PATCH v5 13/20] hw/acpi/aml-build: Add ToUUID macro

2015-04-29 Thread Shannon Zhao
On 2015/4/28 17:48, Shannon Zhao wrote: On 2015/4/28 17:35, Igor Mammedov wrote: On Tue, 28 Apr 2015 16:52:19 +0800 Shannon Zhao wrote: On 2015/4/28 16:15, Igor Mammedov wrote: btw: whole thing might be simpler if an intermediate conversion is avoided, just pack buffer as in spec byte by

Re: [Qemu-devel] [PATCH v5 13/20] hw/acpi/aml-build: Add ToUUID macro

2015-04-28 Thread Shannon Zhao
On 2015/4/28 17:35, Igor Mammedov wrote: > On Tue, 28 Apr 2015 16:52:19 +0800 > Shannon Zhao wrote: > >> On 2015/4/28 16:15, Igor Mammedov wrote: > btw: >>> whole thing might be simpler if an intermediate conversion is avoided, >>> just pack buffer as in spec byte by byte: >>> >>>

Re: [Qemu-devel] [PATCH v5 13/20] hw/acpi/aml-build: Add ToUUID macro

2015-04-28 Thread Igor Mammedov
On Tue, 28 Apr 2015 16:52:19 +0800 Shannon Zhao wrote: > On 2015/4/28 16:15, Igor Mammedov wrote: > >>> btw: > >>> > > whole thing might be simpler if an intermediate conversion is avoided, > >>> > > just pack buffer as in spec byte by byte: > >>> > > > >>> > > /* format: aabbccdd-eeff-gghh-iijj

Re: [Qemu-devel] [PATCH v5 13/20] hw/acpi/aml-build: Add ToUUID macro

2015-04-28 Thread Shannon Zhao
On 2015/4/28 16:15, Igor Mammedov wrote: >>> btw: >>> > > whole thing might be simpler if an intermediate conversion is avoided, >>> > > just pack buffer as in spec byte by byte: >>> > > >>> > > /* format: aabbccdd-eeff-gghh-iijj-kkllmmnnoopp */ >>> > > assert(strlen(uuid) == ...); >>> > > build_a

Re: [Qemu-devel] [PATCH v5 13/20] hw/acpi/aml-build: Add ToUUID macro

2015-04-28 Thread Igor Mammedov
On Tue, 28 Apr 2015 15:46:22 +0800 Shannon Zhao wrote: > On 2015/4/28 14:54, Igor Mammedov wrote: > > On Wed, 15 Apr 2015 21:25:02 +0800 > > Shannon Zhao wrote: > > > >> From: Shannon Zhao > >> > >> Add ToUUID macro, this is useful for generating PCIe ACPI table. > >> > >> Signed-off-by: Shann

Re: [Qemu-devel] [PATCH v5 13/20] hw/acpi/aml-build: Add ToUUID macro

2015-04-28 Thread Shannon Zhao
On 2015/4/28 14:54, Igor Mammedov wrote: > btw: > whole thing might be simpler if an intermediate conversion is avoided, > just pack buffer as in spec byte by byte: > > /* format: aabbccdd-eeff-gghh-iijj-kkllmmnnoopp */ > assert(strlen(uuid) == ...); > build_append_byte(var->buf, HEX2BYTE(uuid[3])

Re: [Qemu-devel] [PATCH v5 13/20] hw/acpi/aml-build: Add ToUUID macro

2015-04-28 Thread Shannon Zhao
On 2015/4/28 14:54, Igor Mammedov wrote: > On Wed, 15 Apr 2015 21:25:02 +0800 > Shannon Zhao wrote: > >> From: Shannon Zhao >> >> Add ToUUID macro, this is useful for generating PCIe ACPI table. >> >> Signed-off-by: Shannon Zhao >> Signed-off-by: Shannon Zhao >> --- >> hw/acpi/aml-build.c

Re: [Qemu-devel] [PATCH v5 13/20] hw/acpi/aml-build: Add ToUUID macro

2015-04-27 Thread Igor Mammedov
On Wed, 15 Apr 2015 21:25:02 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > Add ToUUID macro, this is useful for generating PCIe ACPI table. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/acpi/aml-build.c | 40 >

[Qemu-devel] [PATCH v5 13/20] hw/acpi/aml-build: Add ToUUID macro

2015-04-15 Thread Shannon Zhao
From: Shannon Zhao Add ToUUID macro, this is useful for generating PCIe ACPI table. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/acpi/aml-build.c | 40 include/hw/acpi/aml-build.h | 1 + 2 files changed, 41 insertions(+) dif