Re: [Qemu-devel] [PATCH v5 11/11] nbd: Minimal structured read for client

2017-10-24 Thread Eric Blake
On 10/19/2017 05:26 PM, Eric Blake wrote: > From: Vladimir Sementsov-Ogievskiy > > Minimal implementation: for structured error only error_report error > message. > > + > +/* In-out fields, set by client before nbd_receive_negotiate() and > + * updated by server results during nbd_recei

Re: [Qemu-devel] [PATCH v5 11/11] nbd: Minimal structured read for client

2017-10-23 Thread Vladimir Sementsov-Ogievskiy
23.10.2017 14:57, Eric Blake wrote: On 10/19/2017 05:26 PM, Eric Blake wrote: From: Vladimir Sementsov-Ogievskiy Minimal implementation: for structured error only error_report error message. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Eric Blake +static int nbd_parse_offset_

Re: [Qemu-devel] [PATCH v5 11/11] nbd: Minimal structured read for client

2017-10-23 Thread Eric Blake
On 10/19/2017 05:26 PM, Eric Blake wrote: > From: Vladimir Sementsov-Ogievskiy > > Minimal implementation: for structured error only error_report error > message. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Eric Blake > > +static int nbd_parse_offset_hole_payload(NBDStru

Re: [Qemu-devel] [PATCH v5 11/11] nbd: Minimal structured read for client

2017-10-20 Thread Eric Blake
On 10/20/2017 02:58 PM, Vladimir Sementsov-Ogievskiy wrote: > 20.10.2017 01:26, Eric Blake wrote: >> From: Vladimir Sementsov-Ogievskiy >> >> Minimal implementation: for structured error only error_report error >> message. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> Signed-off-by: Eric B

Re: [Qemu-devel] [PATCH v5 11/11] nbd: Minimal structured read for client

2017-10-20 Thread Vladimir Sementsov-Ogievskiy
20.10.2017 01:26, Eric Blake wrote: From: Vladimir Sementsov-Ogievskiy Minimal implementation: for structured error only error_report error message. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Eric Blake --- v5: fix payload_advance[32,64], return correct negative error on str

[Qemu-devel] [PATCH v5 11/11] nbd: Minimal structured read for client

2017-10-19 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Minimal implementation: for structured error only error_report error message. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Eric Blake --- v5: fix payload_advance[32,64], return correct negative error on structured error, rearrange size checks t