Re: [Qemu-devel] [PATCH v5 1/9] block: add bdrv_measure() API

2017-04-20 Thread Stefan Hajnoczi
On Wed, Apr 19, 2017 at 08:32:06AM -0500, Eric Blake wrote: > On 04/19/2017 08:27 AM, Stefan Hajnoczi wrote: > > >> > >> I know we haven't done a good job in the past, but should we start > >> trying to do better at documenting callback constraints of new things > >> added in this header? > > > >

Re: [Qemu-devel] [PATCH v5 1/9] block: add bdrv_measure() API

2017-04-19 Thread Eric Blake
On 04/19/2017 08:27 AM, Stefan Hajnoczi wrote: >> >> I know we haven't done a good job in the past, but should we start >> trying to do better at documenting callback constraints of new things >> added in this header? > > .bdrv_measure() is a 1:1 pass-through of the public bdrv_measure() > functi

Re: [Qemu-devel] [PATCH v5 1/9] block: add bdrv_measure() API

2017-04-19 Thread Stefan Hajnoczi
On Tue, Apr 18, 2017 at 10:08:20AM -0500, Eric Blake wrote: > On 04/18/2017 08:57 AM, Stefan Hajnoczi wrote: > > bdrv_measure() provides a conservative maximum for the size of a new > > image. This information is handy if storage needs to be allocated (e.g. > > a SAN or an LVM volume) ahead of tim

Re: [Qemu-devel] [PATCH v5 1/9] block: add bdrv_measure() API

2017-04-18 Thread Eric Blake
On 04/18/2017 08:57 AM, Stefan Hajnoczi wrote: > bdrv_measure() provides a conservative maximum for the size of a new > image. This information is handy if storage needs to be allocated (e.g. > a SAN or an LVM volume) ahead of time. > > Signed-off-by: Stefan Hajnoczi > Reviewed-by: Alberto Garci

[Qemu-devel] [PATCH v5 1/9] block: add bdrv_measure() API

2017-04-18 Thread Stefan Hajnoczi
bdrv_measure() provides a conservative maximum for the size of a new image. This information is handy if storage needs to be allocated (e.g. a SAN or an LVM volume) ahead of time. Signed-off-by: Stefan Hajnoczi Reviewed-by: Alberto Garcia --- qapi/block-core.json | 25