Re: [Qemu-devel] [PATCH v5 1/5] Fix configure script for LTTng 2.x

2014-01-14 Thread Stefan Hajnoczi
On Thu, Oct 24, 2013 at 08:46:03PM -0400, Mohamad Gebai wrote: > +if $pkg_config liburcu-bp --exists; then > + urcu_bp_libs=`$pkg_config --libs liburcu-bp` > + else Indentation is off, should be: +if $pkg_config liburcu-bp --exists; then + urcu_bp_libs=`$pkg_config --libs l

Re: [Qemu-devel] [PATCH v5 1/5] Fix configure script for LTTng 2.x

2013-10-25 Thread Mohamad Gebai
On 10/25/2013 10:33 AM, Alex Bennée wrote: mohamad.ge...@polymtl.ca writes: Yes, the bug is actually only in the Ubuntu package (missing liburcu*.pc files). It is fixed everywhere else, including the LTTng PPA. There is a bug report about it on Launchpad. Either ways, this fall back avoids getti

Re: [Qemu-devel] [PATCH v5 1/5] Fix configure script for LTTng 2.x

2013-10-25 Thread Alex Bennée
mohamad.ge...@polymtl.ca writes: >>> Signed-off-by: Mohamad Gebai >>> --- >> >> >> Tested on Ubuntu 12.04 with and without the LTTNG PPA and seems to work >> well enough. >> >> Reviewed-by: Alex Bennée >> > Yes, the bug is actually only in the Ubuntu package (missing liburcu*.pc > files). It

Re: [Qemu-devel] [PATCH v5 1/5] Fix configure script for LTTng 2.x

2013-10-25 Thread Mohamad Gebai
Signed-off-by: Mohamad Gebai --- Tested on Ubuntu 12.04 with and without the LTTNG PPA and seems to work well enough. Reviewed-by: Alex Bennée Yes, the bug is actually only in the Ubuntu package (missing liburcu*.pc files). It is fixed everywhere else, including the LTTng PPA. There is a

Re: [Qemu-devel] [PATCH v5 1/5] Fix configure script for LTTng 2.x

2013-10-25 Thread Alex Bennée
mohamad.ge...@gmail.com writes: > Signed-off-by: Mohamad Gebai > --- Tested on Ubuntu 12.04 with and without the LTTNG PPA and seems to work well enough. Reviewed-by: Alex Bennée -- Alex Bennée

[Qemu-devel] [PATCH v5 1/5] Fix configure script for LTTng 2.x

2013-10-24 Thread Mohamad Gebai
Signed-off-by: Mohamad Gebai --- configure | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 57ee62a..f20ceaa 100755 --- a/configure +++ b/configure @@ -3284,15 +3284,25 @@ fi # For 'ust' backend, test if ust headers are present