Re: [Qemu-devel] [PATCH v5 1/4] qdev: using error_abort instead of using local_err

2014-09-03 Thread Gonglei (Arei)
Hi, > Subject: Re: [Qemu-devel] [PATCH v5 1/4] qdev: using error_abort instead of > using local_err > > Am 02.09.2014 14:03, schrieb arei.gong...@huawei.com: > > From: Gonglei > > > > This error can not happen normally. If it happens indicates > > someth

Re: [Qemu-devel] [PATCH v5 1/4] qdev: using error_abort instead of using local_err

2014-09-03 Thread Andreas Färber
Am 02.09.2014 14:03, schrieb arei.gong...@huawei.com: > From: Gonglei > > This error can not happen normally. If it happens indicates > something very wrong, we should abort QEMU. moreover, The > user can only refer to /machine/peripheral, not > /machine/unattached. > > Meanwhile remove superflu

[Qemu-devel] [PATCH v5 1/4] qdev: using error_abort instead of using local_err

2014-09-02 Thread arei.gonglei
From: Gonglei This error can not happen normally. If it happens indicates something very wrong, we should abort QEMU. moreover, The user can only refer to /machine/peripheral, not /machine/unattached. Meanwhile remove superfluous check about local_err. Signed-off-by: Gonglei Reviewed-by: Peter