Re: [Qemu-devel] [PATCH v5 1/4] Add i.MX FEC Ethernet emulator

2013-06-03 Thread Peter Maydell
On 8 May 2013 09:28, Jean-Christophe DUBOIS wrote: > --- a/include/hw/arm/imx.h > +++ b/include/hw/arm/imx.h > @@ -23,12 +23,10 @@ typedef enum { > > uint32_t imx_clock_frequency(DeviceState *s, IMXClk clock); > > -void imx_timerp_create(const hwaddr addr, > - qemu_irq irq,

Re: [Qemu-devel] [PATCH v5 1/4] Add i.MX FEC Ethernet emulator

2013-05-23 Thread Peter Crosthwaite
Hi JC, All major comments addressed. Few minor suggestions. On Wed, May 8, 2013 at 6:28 PM, Jean-Christophe DUBOIS wrote: > This is based on the mcf_fec.c FEC implementation for ColdFire. > > * a generic phy was added (borrowed from lan9118). > * The buffer management is also modified as

[Qemu-devel] [PATCH v5 1/4] Add i.MX FEC Ethernet emulator

2013-05-08 Thread Jean-Christophe DUBOIS
This is based on the mcf_fec.c FEC implementation for ColdFire. * a generic phy was added (borrowed from lan9118). * The buffer management is also modified as buffers are slightly different between coldfire and i.MX. Signed-off-by: Jean-Christophe DUBOIS --- Changes since V1: