Re: [Qemu-devel] [PATCH v5 1/3] contrib: add ivshmem client and server

2014-09-06 Thread Michael S. Tsirkin
On Fri, Sep 05, 2014 at 02:07:54PM +0200, David Marchand wrote: > Hello Michael, > > On 09/04/2014 05:56 PM, Michael S. Tsirkin wrote: > >>+/* create the unix listening socket */ > >>+sock_fd = socket(AF_UNIX, SOCK_STREAM, 0); > >>+if (sock_fd < 0) { > >>+debug_log(server, "can

Re: [Qemu-devel] [PATCH v5 1/3] contrib: add ivshmem client and server

2014-09-05 Thread David Marchand
Hello Michael, On 09/04/2014 05:56 PM, Michael S. Tsirkin wrote: +/* create the unix listening socket */ +sock_fd = socket(AF_UNIX, SOCK_STREAM, 0); +if (sock_fd < 0) { +debug_log(server, "cannot create socket: %s\n", strerror(errno)); +goto err_close_shm; +} + +

Re: [Qemu-devel] [PATCH v5 1/3] contrib: add ivshmem client and server

2014-09-05 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 02:50:59PM +0200, David Marchand wrote: > When using ivshmem devices, notifications between guests can be sent as > interrupts using a ivshmem-server (typical use described in documentation). > The client is provided as a debug tool. > > Signed-off-by: Olivier Matz > Signe

Re: [Qemu-devel] [PATCH v5 1/3] contrib: add ivshmem client and server

2014-09-05 Thread Claudio Fontana
Just to point out that for the client there is also a DEBUG_LOG to uppercase, just like already pointed out for the server. >> diff --git a/contrib/ivshmem-client/ivshmem-client.c >> b/contrib/ivshmem-client/ivshmem-client.c >> new file mode 100644 >> index 000..ad210c8 >> --- /dev/null >> +

Re: [Qemu-devel] [PATCH v5 1/3] contrib: add ivshmem client and server

2014-09-04 Thread Michael S. Tsirkin
On Thu, Sep 04, 2014 at 02:50:59PM +0200, David Marchand wrote: > When using ivshmem devices, notifications between guests can be sent as > interrupts using a ivshmem-server (typical use described in documentation). > The client is provided as a debug tool. > > Signed-off-by: Olivier Matz > Signe

Re: [Qemu-devel] [PATCH v5 1/3] contrib: add ivshmem client and server

2014-09-04 Thread Michael S. Tsirkin
On Thu, Sep 04, 2014 at 02:50:59PM +0200, David Marchand wrote: > When using ivshmem devices, notifications between guests can be sent as > interrupts using a ivshmem-server (typical use described in documentation). > The client is provided as a debug tool. > > Signed-off-by: Olivier Matz > Signe

[Qemu-devel] [PATCH v5 1/3] contrib: add ivshmem client and server

2014-09-04 Thread David Marchand
When using ivshmem devices, notifications between guests can be sent as interrupts using a ivshmem-server (typical use described in documentation). The client is provided as a debug tool. Signed-off-by: Olivier Matz Signed-off-by: David Marchand --- Makefile|