Re: [Qemu-devel] [PATCH v5 09/24] hpet: fix buffer overrun on invalid state load

2014-04-04 Thread Michael S. Tsirkin
On Fri, Apr 04, 2014 at 06:04:50PM +0300, Michael S. Tsirkin wrote: > On Fri, Apr 04, 2014 at 05:47:39PM +0300, Michael S. Tsirkin wrote: > > On Fri, Apr 04, 2014 at 11:51:52AM +0200, Juan Quintela wrote: > > > "Michael S. Tsirkin" wrote: > > > > CVE-2013-4527 hw/timer/hpet.c buffer overrun > > >

Re: [Qemu-devel] [PATCH v5 09/24] hpet: fix buffer overrun on invalid state load

2014-04-04 Thread Michael S. Tsirkin
On Fri, Apr 04, 2014 at 05:47:39PM +0300, Michael S. Tsirkin wrote: > On Fri, Apr 04, 2014 at 11:51:52AM +0200, Juan Quintela wrote: > > "Michael S. Tsirkin" wrote: > > > CVE-2013-4527 hw/timer/hpet.c buffer overrun > > > > > > hpet is a VARRAY with a uint8 size but static array of 32 > > > > > >

Re: [Qemu-devel] [PATCH v5 09/24] hpet: fix buffer overrun on invalid state load

2014-04-04 Thread Michael S. Tsirkin
On Fri, Apr 04, 2014 at 11:51:52AM +0200, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > CVE-2013-4527 hw/timer/hpet.c buffer overrun > > > > hpet is a VARRAY with a uint8 size but static array of 32 > > > > To fix, make sure num_timers is valid using VMSTATE_VALID hook. > > > > Reported-b

Re: [Qemu-devel] [PATCH v5 09/24] hpet: fix buffer overrun on invalid state load

2014-04-04 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > CVE-2013-4527 hw/timer/hpet.c buffer overrun > > hpet is a VARRAY with a uint8 size but static array of 32 > > To fix, make sure num_timers is valid using VMSTATE_VALID hook. > > Reported-by: Anthony Liguori > Signed-off-by: Michael S. Tsirkin > Reviewed-by: Dr. Dav

[Qemu-devel] [PATCH v5 09/24] hpet: fix buffer overrun on invalid state load

2014-04-03 Thread Michael S. Tsirkin
CVE-2013-4527 hw/timer/hpet.c buffer overrun hpet is a VARRAY with a uint8 size but static array of 32 To fix, make sure num_timers is valid using VMSTATE_VALID hook. Reported-by: Anthony Liguori Signed-off-by: Michael S. Tsirkin Reviewed-by: Dr. David Alan Gilbert --- hw/timer/hpet.c | 13 +