Re: [Qemu-devel] [PATCH v5 07/14] qapi: Utilize implicit struct visits

2016-03-19 Thread Markus Armbruster
Here's how I'd rebase this on the simplified PATCH 06 I just posted as a reply to yours: >From e35449172828351f0acd85f236add45d3eb575a7 Mon Sep 17 00:00:00 2001 From: Eric Blake Date: Wed, 9 Mar 2016 17:55:28 -0700 Subject: [PATCH 07/14] qapi: Utilize implicit struct visits Rather than generate

Re: [Qemu-devel] [PATCH v5 07/14] qapi: Utilize implicit struct visits

2016-03-10 Thread Eric Blake
On 03/10/2016 12:05 PM, Markus Armbruster wrote: > Eric Blake writes: > >> Rather than generate inline per-member visits, take advantage >> of the 'visit_type_FOO_members()' function for both event and >> command marshalling. This is possible now that implicit >> structs can be visited like any

Re: [Qemu-devel] [PATCH v5 07/14] qapi: Utilize implicit struct visits

2016-03-10 Thread Markus Armbruster
Eric Blake writes: > Rather than generate inline per-member visits, take advantage > of the 'visit_type_FOO_members()' function for both event and > command marshalling. This is possible now that implicit > structs can be visited like any other. > > Generated code shrinks accordingly; events ini

[Qemu-devel] [PATCH v5 07/14] qapi: Utilize implicit struct visits

2016-03-09 Thread Eric Blake
Rather than generate inline per-member visits, take advantage of the 'visit_type_FOO_members()' function for both event and command marshalling. This is possible now that implicit structs can be visited like any other. Generated code shrinks accordingly; events initialize a struct based on parame