Re: [Qemu-devel] [PATCH v5 06/11] nbd: Minimal structured read for server

2017-10-23 Thread Eric Blake
On 10/20/2017 02:30 PM, Vladimir Sementsov-Ogievskiy wrote: +    } else if (client->structured_reply) { +    ret = nbd_negotiate_send_rep_err( +    client->ioc, NBD_REP_ERR_INVALID, option, errp, +    "str

Re: [Qemu-devel] [PATCH v5 06/11] nbd: Minimal structured read for server

2017-10-20 Thread Vladimir Sementsov-Ogievskiy
20.10.2017 22:11, Eric Blake wrote: On 10/20/2017 02:03 PM, Vladimir Sementsov-Ogievskiy wrote: 20.10.2017 01:26, Eric Blake wrote: From: Vladimir Sementsov-Ogievskiy Minimal implementation of structured read: one structured reply chunk, no segmentation. Minimal structured error implementatio

Re: [Qemu-devel] [PATCH v5 06/11] nbd: Minimal structured read for server

2017-10-20 Thread Eric Blake
On 10/20/2017 02:03 PM, Vladimir Sementsov-Ogievskiy wrote: > 20.10.2017 01:26, Eric Blake wrote: >> From: Vladimir Sementsov-Ogievskiy >> >> Minimal implementation of structured read: one structured reply chunk, >> no segmentation. >> Minimal structured error implementation: no text message. >> S

Re: [Qemu-devel] [PATCH v5 06/11] nbd: Minimal structured read for server

2017-10-20 Thread Vladimir Sementsov-Ogievskiy
20.10.2017 01:26, Eric Blake wrote: From: Vladimir Sementsov-Ogievskiy Minimal implementation of structured read: one structured reply chunk, no segmentation. Minimal structured error implementation: no text message. Support DF flag, but just ignore it, as there is no segmentation any way. Sig

[Qemu-devel] [PATCH v5 06/11] nbd: Minimal structured read for server

2017-10-19 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Minimal implementation of structured read: one structured reply chunk, no segmentation. Minimal structured error implementation: no text message. Support DF flag, but just ignore it, as there is no segmentation any way. Signed-off-by: Vladimir Sementsov-Ogievsk