Re: [Qemu-devel] [PATCH v5 03/15] target/mips: Access MemoryRegion with MemOp

2019-07-26 Thread Richard Henderson
On 7/25/19 11:44 PM, tony.ngu...@bt.com wrote: > memory_region_dispatch_read(env->itc_tag, index, &env->CP0_TagLo, > -8, MEMTXATTRS_UNSPECIFIED); > +SIZE_MEMOP(8), MEMTXATTRS_UNSPECIFIED); As an example of why I'm not

[Qemu-devel] [PATCH v5 03/15] target/mips: Access MemoryRegion with MemOp

2019-07-25 Thread tony.nguyen
No-op SIZE_MEMOP macro allows us to later easily convert memory_region_dispatch_{read|write} paramter "unsigned size" into a size+sign+endianness encoded "MemOp op". Being a no-op macro, this patch does not introduce any logical change. Signed-off-by: Tony Nguyen Reviewed-by: Philippe Mathieu-Da