Re: [Qemu-devel] [PATCH v5 02/15] ssi: Added VMSD stub

2012-08-09 Thread Peter Crosthwaite
On Mon, 2012-08-06 at 10:13 +0100, Peter Maydell wrote: > On 6 August 2012 03:16, Peter A. G. Crosthwaite > wrote: > > Added VMSD stub for SSI slaves. Fields may be added to this VMSD for generic > > SSI slave state (e.g. the CS line state). > > This is more me being confused about how this shoul

Re: [Qemu-devel] [PATCH v5 02/15] ssi: Added VMSD stub

2012-08-06 Thread Peter Maydell
On 6 August 2012 10:13, Peter Maydell wrote: > On 6 August 2012 03:16, Peter A. G. Crosthwaite > wrote: >> Added VMSD stub for SSI slaves. Fields may be added to this VMSD for generic >> SSI slave state (e.g. the CS line state). > > This is more me being confused about how this should work than a

Re: [Qemu-devel] [PATCH v5 02/15] ssi: Added VMSD stub

2012-08-06 Thread Peter Maydell
On 6 August 2012 03:16, Peter A. G. Crosthwaite wrote: > Added VMSD stub for SSI slaves. Fields may be added to this VMSD for generic > SSI slave state (e.g. the CS line state). This is more me being confused about how this should work than a review comment, but it seems a bit odd that we have a

[Qemu-devel] [PATCH v5 02/15] ssi: Added VMSD stub

2012-08-05 Thread Peter A. G. Crosthwaite
Added VMSD stub for SSI slaves. Fields may be added to this VMSD for generic SSI slave state (e.g. the CS line state). Signed-off-by: Peter A. G. Crosthwaite --- hw/ads7846.c |1 + hw/max111x.c |1 + hw/spitz.c |2 ++ hw/ssi.c | 10 ++ hw/ssi.h | 10 ++