Re: [Qemu-devel] [PATCH v5 00/28] drop qapi nested structs

2015-03-30 Thread Eric Blake
On 03/29/2015 10:03 AM, Markus Armbruster wrote: > What happens when I define a member key multiple times in a struct or > union type? > > If I do it directly, the parser rejects the duplicate key in > get_members(). Covered by tests/qapi-schema/duplicate-key.json. > > What if I hide the duplica

Re: [Qemu-devel] [PATCH v5 00/28] drop qapi nested structs

2015-03-29 Thread Markus Armbruster
What happens when I define a member key multiple times in a struct or union type? If I do it directly, the parser rejects the duplicate key in get_members(). Covered by tests/qapi-schema/duplicate-key.json. What if I hide the duplicate in a base type? If I stick this into qapi-schema-test.json:

Re: [Qemu-devel] [PATCH v5 00/28] drop qapi nested structs

2015-03-27 Thread Markus Armbruster
Eric Blake writes: > After several months of sitting on this, I finally made progress > on it. Let's get it in 2.4, and I promise to kick out a v6 > (if needed) with much less delay. > > We want to eventually allow qapi defaults, by making: > 'data':{'*flag':'bool'} > shorthand for: > 'data':{

[Qemu-devel] [PATCH v5 00/28] drop qapi nested structs

2015-03-24 Thread Eric Blake
After several months of sitting on this, I finally made progress on it. Let's get it in 2.4, and I promise to kick out a v6 (if needed) with much less delay. We want to eventually allow qapi defaults, by making: 'data':{'*flag':'bool'} shorthand for: 'data':{'flag':{'type':'bool', 'optional':tr