Re: [Qemu-devel] [PATCH v5 00/18] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-05-09 Thread Paolo Bonzini
On 03/05/2016 06:38, Jan Kiszka wrote: > Yes, this doesn't look good from the performance POV. Given that most > EOIs of the APICs will not trigger a message to an IOAPIC and userspace > exits are expensive, that should be measurable. > > But you should optimize route updating a bit: I noticed r

Re: [Qemu-devel] [PATCH v5 00/18] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-05-02 Thread Jan Kiszka
On 2016-05-03 08:00, Peter Xu wrote: > On Tue, May 03, 2016 at 07:40:50AM +0200, Jan Kiszka wrote: >> On 2016-05-03 07:30, Peter Xu wrote: >>> On Tue, May 03, 2016 at 06:38:28AM +0200, Jan Kiszka wrote: On 2016-05-03 05:22, Peter Xu wrote: > On Fri, Apr 29, 2016 at 09:52:14PM +0200, Radim

Re: [Qemu-devel] [PATCH v5 00/18] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-05-02 Thread Peter Xu
On Tue, May 03, 2016 at 07:40:50AM +0200, Jan Kiszka wrote: > On 2016-05-03 07:30, Peter Xu wrote: > > On Tue, May 03, 2016 at 06:38:28AM +0200, Jan Kiszka wrote: > >> On 2016-05-03 05:22, Peter Xu wrote: > >>> On Fri, Apr 29, 2016 at 09:52:14PM +0200, Radim Krčmář wrote: > 2016-04-28 17:18+08

Re: [Qemu-devel] [PATCH v5 00/18] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-05-02 Thread Jan Kiszka
On 2016-05-03 07:30, Peter Xu wrote: > On Tue, May 03, 2016 at 06:38:28AM +0200, Jan Kiszka wrote: >> On 2016-05-03 05:22, Peter Xu wrote: >>> On Fri, Apr 29, 2016 at 09:52:14PM +0200, Radim Krčmář wrote: 2016-04-28 17:18+0800, Peter Xu: > On Thu, Apr 28, 2016 at 09:19:28AM +0200, Jan Kisz

Re: [Qemu-devel] [PATCH v5 00/18] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-05-02 Thread Peter Xu
On Tue, May 03, 2016 at 06:38:28AM +0200, Jan Kiszka wrote: > On 2016-05-03 05:22, Peter Xu wrote: > > On Fri, Apr 29, 2016 at 09:52:14PM +0200, Radim Krčmář wrote: > >> 2016-04-28 17:18+0800, Peter Xu: > >>> On Thu, Apr 28, 2016 at 09:19:28AM +0200, Jan Kiszka wrote: > Instead of fiddling wit

Re: [Qemu-devel] [PATCH v5 00/18] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-05-02 Thread Jan Kiszka
On 2016-05-03 05:22, Peter Xu wrote: > On Fri, Apr 29, 2016 at 09:52:14PM +0200, Radim Krčmář wrote: >> 2016-04-28 17:18+0800, Peter Xu: >>> On Thu, Apr 28, 2016 at 09:19:28AM +0200, Jan Kiszka wrote: Instead of fiddling with irq routes for the IOAPIC - where we don't need it -, I would s

Re: [Qemu-devel] [PATCH v5 00/18] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-05-02 Thread Peter Xu
On Fri, Apr 29, 2016 at 09:52:14PM +0200, Radim Krčmář wrote: > 2016-04-28 17:18+0800, Peter Xu: > > On Thu, Apr 28, 2016 at 09:19:28AM +0200, Jan Kiszka wrote: > >> Instead of fiddling with irq routes for the IOAPIC - where we don't need > >> it -, I would suggest to do the following: Send IOAPIC

Re: [Qemu-devel] [PATCH v5 00/18] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-29 Thread Radim Krčmář
2016-04-28 17:18+0800, Peter Xu: > On Thu, Apr 28, 2016 at 09:19:28AM +0200, Jan Kiszka wrote: >> Instead of fiddling with irq routes for the IOAPIC - where we don't need >> it -, I would suggest to do the following: Send IOAPIC events via >> kvm_irqchip_send_msi to the kernel. Only irqfd users (vh

Re: [Qemu-devel] [PATCH v5 00/18] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-28 Thread Jan Kiszka
On 2016-04-28 11:18, Peter Xu wrote: > On Thu, Apr 28, 2016 at 09:19:28AM +0200, Jan Kiszka wrote: >> On 2016-04-28 09:05, Peter Xu wrote: >>> v5 changes: >>> - patch 10: add vector checking for IOAPIC interrupts (this may help >>> debug in the future, will only generate warning if specify >>>

Re: [Qemu-devel] [PATCH v5 00/18] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-28 Thread Peter Xu
On Thu, Apr 28, 2016 at 09:19:28AM +0200, Jan Kiszka wrote: > On 2016-04-28 09:05, Peter Xu wrote: > > v5 changes: > > - patch 10: add vector checking for IOAPIC interrupts (this may help > > debug in the future, will only generate warning if specify > > IOMMU_DEBUG) > > - patch 13: replace err

Re: [Qemu-devel] [PATCH v5 00/18] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-28 Thread Jan Kiszka
On 2016-04-28 09:05, Peter Xu wrote: > v5 changes: > - patch 10: add vector checking for IOAPIC interrupts (this may help > debug in the future, will only generate warning if specify > IOMMU_DEBUG) > - patch 13: replace error_report() with a trace. [Jan] > - patch 14: rename parameter "intr" to

Re: [Qemu-devel] [PATCH v5 00/18] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-28 Thread Peter Xu
On Thu, Apr 28, 2016 at 03:05:26PM +0800, Peter Xu wrote: > v5 changes: > - patch 10: add vector checking for IOAPIC interrupts (this may help > debug in the future, will only generate warning if specify > IOMMU_DEBUG) > - patch 13: replace error_report() with a trace. [Jan] > - patch 14: renam

[Qemu-devel] [PATCH v5 00/18] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-28 Thread Peter Xu
v5 changes: - patch 10: add vector checking for IOAPIC interrupts (this may help debug in the future, will only generate warning if specify IOMMU_DEBUG) - patch 13: replace error_report() with a trace. [Jan] - patch 14: rename parameter "intr" to "intremap", to be aligned with kernel paramete