Re: [Qemu-devel] [PATCH v5 0/7] virtio-serial refactoring.

2013-04-08 Thread KONRAD Frédéric
On 08/04/2013 19:16, Peter Maydell wrote: On 8 April 2013 18:14, KONRAD Frédéric wrote: On 08/04/2013 19:03, Peter Maydell wrote: You specifically don't want to change the register_savevm name, because otherwise you'll break migration (we use the ID string to identify what incoming migration d

Re: [Qemu-devel] [PATCH v5 0/7] virtio-serial refactoring.

2013-04-08 Thread Peter Maydell
On 8 April 2013 18:14, KONRAD Frédéric wrote: > On 08/04/2013 19:03, Peter Maydell wrote: >> You specifically don't want to change the register_savevm name, >> because otherwise you'll break migration (we use the ID string >> to identify what incoming migration data is). > Ok, you mean migration

Re: [Qemu-devel] [PATCH v5 0/7] virtio-serial refactoring.

2013-04-08 Thread KONRAD Frédéric
On 08/04/2013 19:03, Peter Maydell wrote: On 8 April 2013 18:00, KONRAD Frédéric wrote: I'm making a patch for that, and I'm wondering if the name in register_savevm must be changed too? eg for virtio-balloon: -register_savevm(qdev, "virtio-balloon", -1, 1, +register_savevm(qdev, TYPE

Re: [Qemu-devel] [PATCH v5 0/7] virtio-serial refactoring.

2013-04-08 Thread Peter Maydell
On 8 April 2013 18:00, KONRAD Frédéric wrote: > I'm making a patch for that, and I'm wondering if the name in > register_savevm must be changed too? > > eg for virtio-balloon: > > -register_savevm(qdev, "virtio-balloon", -1, 1, > +register_savevm(qdev, TYPE_VIRTIO_BALLOON, -1, 1, >

Re: [Qemu-devel] [PATCH v5 0/7] virtio-serial refactoring.

2013-04-08 Thread KONRAD Frédéric
On 05/04/2013 17:36, Anthony Liguori wrote: fred.kon...@greensocs.com writes: From: KONRAD Frederic This is the next part of virtio-refactoring. Basically it creates virtio-serial device which extends virtio-device. Then a virtio-serial can be connected on a virtio-bus. virtio-serial-pci, vi

Re: [Qemu-devel] [PATCH v5 0/7] virtio-serial refactoring.

2013-04-05 Thread Anthony Liguori
fred.kon...@greensocs.com writes: > From: KONRAD Frederic > > This is the next part of virtio-refactoring. > > Basically it creates virtio-serial device which extends virtio-device. > Then a virtio-serial can be connected on a virtio-bus. > virtio-serial-pci, virtio-serial-s390 and virtio-serial-

Re: [Qemu-devel] [PATCH v5 0/7] virtio-serial refactoring.

2013-04-04 Thread Peter Maydell
On 4 April 2013 15:28, wrote: > From: KONRAD Frederic > > This is the next part of virtio-refactoring. > > Basically it creates virtio-serial device which extends virtio-device. > Then a virtio-serial can be connected on a virtio-bus. > virtio-serial-pci, virtio-serial-s390 and virtio-serial-ccw

Re: [Qemu-devel] [PATCH v5 0/7] virtio-serial refactoring.

2013-04-04 Thread Cornelia Huck
On Thu, 4 Apr 2013 16:28:58 +0200 fred.kon...@greensocs.com wrote: > From: KONRAD Frederic > > This is the next part of virtio-refactoring. > > Basically it creates virtio-serial device which extends virtio-device. > Then a virtio-serial can be connected on a virtio-bus. > virtio-serial-pci, v

[Qemu-devel] [PATCH v5 0/7] virtio-serial refactoring.

2013-04-04 Thread fred . konrad
From: KONRAD Frederic This is the next part of virtio-refactoring. Basically it creates virtio-serial device which extends virtio-device. Then a virtio-serial can be connected on a virtio-bus. virtio-serial-pci, virtio-serial-s390 and virtio-serial-ccw are created too, they extend respectively v