Re: [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support

2013-08-01 Thread Andreas Färber
Am 01.08.2013 11:38, schrieb Stefan Hajnoczi: > On Wed, Jul 31, 2013 at 03:39:05PM +0200, Vincenzo Maffione wrote: >> Ok, but it's unclear how do you prefer to create and "empty" >> PC_COMPAT_1_6 in Patch 1. >> If you want to keep this declaration form >> >> [...] >> .compat_props = (GlobalProperty

Re: [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support

2013-08-01 Thread Vincenzo Maffione
Ok, so back to the one-patch version! :) I'll prepare it asap. Thanks, Vincenzo 2013/8/1 Andreas Färber : > Am 01.08.2013 11:38, schrieb Stefan Hajnoczi: >> On Wed, Jul 31, 2013 at 03:39:05PM +0200, Vincenzo Maffione wrote: >>> Ok, but it's unclear how do you prefer to create and "empty" >>> PC

Re: [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support

2013-08-01 Thread Stefan Hajnoczi
On Wed, Jul 31, 2013 at 03:39:05PM +0200, Vincenzo Maffione wrote: > Ok, but it's unclear how do you prefer to create and "empty" > PC_COMPAT_1_6 in Patch 1. > If you want to keep this declaration form > > [...] > .compat_props = (GlobalProperty[]) { > PC_COMPAT_1_6, > { /* end of

Re: [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support

2013-07-31 Thread Vincenzo Maffione
Ok, but it's unclear how do you prefer to create and "empty" PC_COMPAT_1_6 in Patch 1. If you want to keep this declaration form [...] .compat_props = (GlobalProperty[]) { PC_COMPAT_1_6, { /* end of list */ } }, [...] in the two pc_*_machine_v1_6 structs, I'm forced to define

Re: [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support

2013-07-31 Thread Andreas Färber
Am 31.07.2013 13:20, schrieb Stefan Hajnoczi: > On Wed, Jul 31, 2013 at 12:19:06PM +0200, Vincenzo Maffione wrote: >> Sorry, I'm not confident with this infrastructure. > > Thanks for your efforts! Normally this change would not be necessary > but you are the first person who needs a 1.6 compat p

Re: [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support

2013-07-31 Thread Stefan Hajnoczi
On Wed, Jul 31, 2013 at 12:19:06PM +0200, Vincenzo Maffione wrote: > Sorry, I'm not confident with this infrastructure. Thanks for your efforts! Normally this change would not be necessary but you are the first person who needs a 1.6 compat property :). > So do you just want me to invert the com

Re: [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support

2013-07-31 Thread Vincenzo Maffione
Sorry, I'm not confident with this infrastructure. So do you just want me to invert the commit order? (and do the other two little changes) Thanks, Vincenzo 2013/7/31 Andreas Färber : > Am 31.07.2013 10:13, schrieb Vincenzo Maffione: >> Implement interrupt mitigation for the e1000 device with

Re: [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support

2013-07-31 Thread Andreas Färber
Am 31.07.2013 10:13, schrieb Vincenzo Maffione: > Implement interrupt mitigation for the e1000 device with the > corresponding "mitigation" device property. > > Add a compat_props entry to pc-1.6 machines in order to set the > "mitigation" property for these machines. > > Vincenzo Maffione (2): >

[Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support

2013-07-31 Thread Vincenzo Maffione
Implement interrupt mitigation for the e1000 device with the corresponding "mitigation" device property. Add a compat_props entry to pc-1.6 machines in order to set the "mitigation" property for these machines. Vincenzo Maffione (2): e1000: add interrupt mitigation support i386/pc: introducin