o Habkost
To: qemu-devel@nongnu.org
Message-ID: <20150522191355.gg28...@thinpad.lan.raisama.net>
Subject: Re: [Qemu-devel] [PATCH v5] target-i386: Register QOM properties for
feature flags
Now that the object_property_add_alias() patch was merged, we can remove
hte g_strdup() call.
--
Eduardo
On 14/04/2015 17:28, Eduardo Habkost wrote:
> +for (i = 1; names[i]; i++) {
> +feat2prop(names[i]);
> +object_property_add_alias(obj, names[i], obj, names[0],
> &error_abort);
The version you committed has a strdup(names[0]) here, but
object_property_add_alias already does a
On Tue, Apr 14, 2015 at 12:28:24PM -0300, Eduardo Habkost wrote:
> This uses the feature name arrays to register QOM properties for feature
> flags. This simply adds properties that can be configured using -global,
> but doesn't change x86_cpu_parse_featurestr() to use them yet.
>
> Signed-off-by:
On Tue, 14 Apr 2015 12:28:24 -0300
Eduardo Habkost wrote:
> This uses the feature name arrays to register QOM properties for feature
> flags. This simply adds properties that can be configured using -global,
> but doesn't change x86_cpu_parse_featurestr() to use them yet.
>
> Signed-off-by: Edua
This uses the feature name arrays to register QOM properties for feature
flags. This simply adds properties that can be configured using -global,
but doesn't change x86_cpu_parse_featurestr() to use them yet.
Signed-off-by: Eduardo Habkost
---
Changes v1 -> v2:
* Use "cpuid-" prefix instead of "f