Re: [Qemu-devel] [PATCH v5] hw/unicore32: remove wrong assertion in puv machine init

2017-03-31 Thread Thomas Huth
On 30.03.2017 18:50, Suramya Shah wrote: > Running QEMU with qemu-system-unicore32 without the kernel parameter results > in an assertion error. > Assert should not be used to check user provided parameters. Report an error > and exit instead > Signed-off-by: Suramya Shah Nit: There should be a

Re: [Qemu-devel] [PATCH v5] hw/unicore32: remove wrong assertion in puv machine init

2017-03-30 Thread Xuetao Guan
> On 03/30/2017 07:50 PM, Suramya Shah wrote: >> Running QEMU with qemu-system-unicore32 without the kernel parameter >> results in an assertion error. >> Assert should not be used to check user provided parameters. Report an >> error and exit instead >> Signed-off-by: Suramya Shah Thanks Suramya

Re: [Qemu-devel] [PATCH v5] hw/unicore32: remove wrong assertion in puv machine init

2017-03-30 Thread Marcel Apfelbaum
On 03/30/2017 07:50 PM, Suramya Shah wrote: Running QEMU with qemu-system-unicore32 without the kernel parameter results in an assertion error. Assert should not be used to check user provided parameters. Report an error and exit instead Signed-off-by: Suramya Shah --- hw/unicore32/puv3.c | 7

[Qemu-devel] [PATCH v5] hw/unicore32: remove wrong assertion in puv machine init

2017-03-30 Thread Suramya Shah
Running QEMU with qemu-system-unicore32 without the kernel parameter results in an assertion error. Assert should not be used to check user provided parameters. Report an error and exit instead Signed-off-by: Suramya Shah --- hw/unicore32/puv3.c | 7 +-- 1 file changed, 5 insertions(+), 2