Re: [Qemu-devel] [PATCH v5] block:add-cow file format

2011-12-06 Thread Marcelo Tosatti
On Tue, Dec 06, 2011 at 02:35:03PM -0200, Marcelo Tosatti wrote: > > Right, we can probably generalise the qcow2 code and make it available > > for other drivers as well. > > Hum, generalising sounds overly complicated (and there is a time > constraint to this). IMHO a cache internal to add-cow.c

Re: [Qemu-devel] [PATCH v5] block:add-cow file format

2011-12-06 Thread Kevin Wolf
Am 06.12.2011 17:35, schrieb Marcelo Tosatti: > On Tue, Dec 06, 2011 at 04:20:55PM +0100, Kevin Wolf wrote: >> Am 06.12.2011 16:06, schrieb Marcelo Tosatti: >>> On Tue, Dec 06, 2011 at 12:53:16PM -0200, Marcelo Tosatti wrote: On Tue, Dec 06, 2011 at 01:59:48PM +0100, Kevin Wolf wrote: >>>

Re: [Qemu-devel] [PATCH v5] block:add-cow file format

2011-12-06 Thread Marcelo Tosatti
On Tue, Dec 06, 2011 at 04:20:55PM +0100, Kevin Wolf wrote: > Am 06.12.2011 16:06, schrieb Marcelo Tosatti: > > On Tue, Dec 06, 2011 at 12:53:16PM -0200, Marcelo Tosatti wrote: > >> On Tue, Dec 06, 2011 at 01:59:48PM +0100, Kevin Wolf wrote: > > + > > +ret = bdrv_pread(bs->file, sizeof(

Re: [Qemu-devel] [PATCH v5] block:add-cow file format

2011-12-06 Thread Kevin Wolf
Am 06.12.2011 16:06, schrieb Marcelo Tosatti: > On Tue, Dec 06, 2011 at 12:53:16PM -0200, Marcelo Tosatti wrote: >> On Tue, Dec 06, 2011 at 01:59:48PM +0100, Kevin Wolf wrote: > + > +ret = bdrv_pread(bs->file, sizeof(header), state->bitmap, > +state->bitmap_size); >

Re: [Qemu-devel] [PATCH v5] block:add-cow file format

2011-12-06 Thread Kevin Wolf
Am 06.12.2011 15:53, schrieb Marcelo Tosatti: > On Tue, Dec 06, 2011 at 01:59:48PM +0100, Kevin Wolf wrote: + +ret = bdrv_pread(bs->file, sizeof(header), state->bitmap, +state->bitmap_size); +if (ret != state->bitmap_size) { +goto fail; +

Re: [Qemu-devel] [PATCH v5] block:add-cow file format

2011-12-06 Thread Marcelo Tosatti
On Tue, Dec 06, 2011 at 12:53:16PM -0200, Marcelo Tosatti wrote: > On Tue, Dec 06, 2011 at 01:59:48PM +0100, Kevin Wolf wrote: > > >> + > > >> +ret = bdrv_pread(bs->file, sizeof(header), state->bitmap, > > >> +state->bitmap_size); > > >> +if (ret != state->bitmap_size) { > > >>

Re: [Qemu-devel] [PATCH v5] block:add-cow file format

2011-12-06 Thread Marcelo Tosatti
On Tue, Dec 06, 2011 at 01:59:48PM +0100, Kevin Wolf wrote: > >> + > >> +ret = bdrv_pread(bs->file, sizeof(header), state->bitmap, > >> +state->bitmap_size); > >> +if (ret != state->bitmap_size) { > >> +goto fail; > >> +} > > > > Reading the entire bitmap in memory

Re: [Qemu-devel] [PATCH v5] block:add-cow file format

2011-12-06 Thread Kevin Wolf
Am 15.11.2011 06:28, schrieb Dong Xu Wang: > From: Dong Xu Wang > > Provide a new file format: add-cow. The usage can be found in add-cow.txt of > this patch. > > Signed-off-by: Dong Xu Wang > --- > Makefile.objs |1 + > block.c|2 +- > block.h|

Re: [Qemu-devel] [PATCH v5] block:add-cow file format

2011-12-06 Thread Kevin Wolf
Am 06.12.2011 13:48, schrieb Marcelo Tosatti: > On Tue, Nov 15, 2011 at 01:28:51PM +0800, Dong Xu Wang wrote: >> From: Dong Xu Wang >> >> Provide a new file format: add-cow. The usage can be found in add-cow.txt of >> this patch. >> >> Signed-off-by: Dong Xu Wang >> --- >> Makefile.objs

Re: [Qemu-devel] [PATCH v5] block:add-cow file format

2011-12-06 Thread Marcelo Tosatti
On Tue, Nov 15, 2011 at 01:28:51PM +0800, Dong Xu Wang wrote: > From: Dong Xu Wang > > Provide a new file format: add-cow. The usage can be found in add-cow.txt of > this patch. > > Signed-off-by: Dong Xu Wang > --- > Makefile.objs |1 + > block.c|2 +- > block

Re: [Qemu-devel] [PATCH v5] block:add-cow file format

2011-12-04 Thread Dong Xu Wang
Ping... 2011/11/28 Dong Xu Wang > Any comment? > Thanks. > > > 2011/11/15 Dong Xu Wang > >> From: Dong Xu Wang >> >> Provide a new file format: add-cow. The usage can be found in add-cow.txt >> of >> this patch. >> >> Signed-off-by: Dong Xu Wang >> --- >> Makefile.objs |1 + >>

Re: [Qemu-devel] [PATCH v5] block:add-cow file format

2011-11-27 Thread Dong Xu Wang
Any comment? Thanks. 2011/11/15 Dong Xu Wang > From: Dong Xu Wang > > Provide a new file format: add-cow. The usage can be found in add-cow.txt > of > this patch. > > Signed-off-by: Dong Xu Wang > --- > Makefile.objs |1 + > block.c|2 +- > block.h

[Qemu-devel] [PATCH v5] block:add-cow file format

2011-11-14 Thread Dong Xu Wang
From: Dong Xu Wang Provide a new file format: add-cow. The usage can be found in add-cow.txt of this patch. Signed-off-by: Dong Xu Wang --- Makefile.objs |1 + block.c|2 +- block.h|1 + block/add-cow.c| 417