Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-09 Thread Stefano Stabellini
On Mon, 8 Jul 2013, Anthony Liguori wrote: > Stefano Stabellini writes: > > > On Mon, 8 Jul 2013, Anthony Liguori wrote: > >> Andreas Färber writes: > >> > >> Right, it goes: > >> > >> 1) Acked-by: > >> > >> I haven't reviewed the code in detail but the general idea seems sane. > >> > >> 2)

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Anthony Liguori
Stefano Stabellini writes: > On Mon, 8 Jul 2013, Anthony Liguori wrote: >> Andreas Färber writes: >> >> Right, it goes: >> >> 1) Acked-by: >> >> I haven't reviewed the code in detail but the general idea seems sane. >> >> 2) Reviewed-by: >> >> The general idea seems sane, and I have done a

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Stefano Stabellini
On Mon, 8 Jul 2013, Stefano Stabellini wrote: > On Mon, 8 Jul 2013, Anthony Liguori wrote: > > Andreas Färber writes: > > > > > Am 08.07.2013 16:10, schrieb Peter Maydell: > > >> On 8 July 2013 15:04, Anthony Liguori wrote: > > >>> (Just a nit and responding because this happens commonly). > > >

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Stefano Stabellini
On Mon, 8 Jul 2013, Anthony Liguori wrote: > Andreas Färber writes: > > > Am 08.07.2013 16:10, schrieb Peter Maydell: > >> On 8 July 2013 15:04, Anthony Liguori wrote: > >>> (Just a nit and responding because this happens commonly). > >>> > >>> You probably mean Reviewed-by. Acked-by really mea

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Andreas Färber
Am 08.07.2013 17:34, schrieb Peter Maydell: > On 8 July 2013 16:20, Anthony Liguori wrote: >> Right, it goes: >> >> 1) Acked-by: >> >> I haven't reviewed the code in detail but the general idea seems sane. >> >> 2) Reviewed-by: >> >> The general idea seems sane, and I have done a thorough review o

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Peter Maydell
On 8 July 2013 16:20, Anthony Liguori wrote: > Right, it goes: > > 1) Acked-by: > > I haven't reviewed the code in detail but the general idea seems sane. > > 2) Reviewed-by: > > The general idea seems sane, and I have done a thorough review of the > patch in question. > > 3) Signed-off-by: > > Al

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Anthony Liguori
Andreas Färber writes: > Am 08.07.2013 16:10, schrieb Peter Maydell: >> On 8 July 2013 15:04, Anthony Liguori wrote: >>> (Just a nit and responding because this happens commonly). >>> >>> You probably mean Reviewed-by. Acked-by really means, "I am not the >>> maintainer of this area, I have not

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Anthony Liguori
Peter Maydell writes: > On 8 July 2013 15:04, Anthony Liguori wrote: >> (Just a nit and responding because this happens commonly). >> >> You probably mean Reviewed-by. Acked-by really means, "I am not the >> maintainer of this area, I have not reviewed this patch, but I am >> generally okay wit

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Andreas Färber
Am 08.07.2013 16:10, schrieb Peter Maydell: > On 8 July 2013 15:04, Anthony Liguori wrote: >> (Just a nit and responding because this happens commonly). >> >> You probably mean Reviewed-by. Acked-by really means, "I am not the >> maintainer of this area, I have not reviewed this patch, but I am >

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Alex Bligh
--On 8 July 2013 15:10:49 +0100 Peter Maydell wrote: You probably mean Reviewed-by. Acked-by really means, "I am not the maintainer of this area, I have not reviewed this patch, but I am generally okay with the idea as best I can tell." Don't you mean "I *am* the maintainer of this area"

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Peter Maydell
On 8 July 2013 15:04, Anthony Liguori wrote: > (Just a nit and responding because this happens commonly). > > You probably mean Reviewed-by. Acked-by really means, "I am not the > maintainer of this area, I have not reviewed this patch, but I am > generally okay with the idea as best I can tell."

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Anthony Liguori
Paul Durrant writes: > Introduces a new Xen PV PCI device which will act as a binding point for > PV drivers for Xen. > The device has parameterized vendor-id, device-id and revision to allow to > be configured as a binding point for any vendor's PV drivers. > > Signed-off-by: Paul Durrant > Cc:

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Anthony Liguori
Stefano Stabellini writes: > On Thu, 4 Jul 2013, Paul Durrant wrote: >> Introduces a new Xen PV PCI device which will act as a binding point for >> PV drivers for Xen. >> The device has parameterized vendor-id, device-id and revision to allow to >> be configured as a binding point for any vendor'

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-04 Thread Stefano Stabellini
On Thu, 4 Jul 2013, Paul Durrant wrote: > Introduces a new Xen PV PCI device which will act as a binding point for > PV drivers for Xen. > The device has parameterized vendor-id, device-id and revision to allow to > be configured as a binding point for any vendor's PV drivers. > > Signed-off-by: P

[Qemu-devel] [PATCH v5] Xen PV Device

2013-07-04 Thread Paul Durrant
Introduces a new Xen PV PCI device which will act as a binding point for PV drivers for Xen. The device has parameterized vendor-id, device-id and revision to allow to be configured as a binding point for any vendor's PV drivers. Signed-off-by: Paul Durrant Cc: Stefano Stabellini Reviewed-by: An