Re: [Qemu-devel] [PATCH v5] Add optionrom compatible with fw_cfg DMA version

2016-04-26 Thread Richard W.M. Jones
On Tue, Apr 26, 2016 at 09:43:09AM +0200, Gerd Hoffmann wrote: > On Fr, 2016-04-22 at 14:02 +0100, Richard W.M. Jones wrote: > > v4 -> v5: > > > > * Fix the initrd loading problem by fixing the get_e801_addr > >function so it really reads the values from the BIOS. > > > > Previously the func

Re: [Qemu-devel] [PATCH v5] Add optionrom compatible with fw_cfg DMA version

2016-04-26 Thread Gerd Hoffmann
On Fr, 2016-04-22 at 14:02 +0100, Richard W.M. Jones wrote: > v4 -> v5: > > * Fix the initrd loading problem by fixing the get_e801_addr >function so it really reads the values from the BIOS. > > Previously the function always returned 16MB, and so it only happened > to work for initrd sizes

Re: [Qemu-devel] [PATCH v5] Add optionrom compatible with fw_cfg DMA version

2016-04-25 Thread Stefan Hajnoczi
On Fri, Apr 22, 2016 at 02:02:28PM +0100, Richard W.M. Jones wrote: > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 99437e0..e11152d 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c > @@ -999,8 +999,13 @@ static void load_linux(PCMachineState *pcms, > fw_cfg_add_i32(fw_cfg, FW_CFG_SETUP_SIZ

Re: [Qemu-devel] [PATCH v5] Add optionrom compatible with fw_cfg DMA version

2016-04-24 Thread Marc Marí
On Fri, 22 Apr 2016 14:02:28 +0100 "Richard W.M. Jones" wrote: > From: Marc Marí > > This optionrom is based on linuxboot.S. > > Signed-off-by: Marc Marí > Signed-off-by: Richard W.M. Jones > --- > .gitignore| 4 + > hw/i386/pc.c | 9 +- > hw

[Qemu-devel] [PATCH v5] Add optionrom compatible with fw_cfg DMA version

2016-04-22 Thread Richard W.M. Jones
v4 -> v5: * Fix the initrd loading problem by fixing the get_e801_addr function so it really reads the values from the BIOS. Previously the function always returned 16MB, and so it only happened to work for initrd sizes < ~15MB, and broke for anything larger. Now the function is fixed, I tes

[Qemu-devel] [PATCH v5] Add optionrom compatible with fw_cfg DMA version

2016-04-22 Thread Richard W.M. Jones
From: Marc Marí This optionrom is based on linuxboot.S. Signed-off-by: Marc Marí Signed-off-by: Richard W.M. Jones --- .gitignore| 4 + hw/i386/pc.c | 9 +- hw/nvram/fw_cfg.c | 2 +- include/hw/nvram/fw_cfg.h | 1 +