Re: [Qemu-devel] [PATCH v4 RFC 9/8] nbd: Minimal structured read for client

2017-10-19 Thread Eric Blake
On 10/17/2017 04:17 PM, Eric Blake wrote: > On 10/17/2017 07:57 AM, Vladimir Sementsov-Ogievskiy wrote: >> Minimal implementation: for structured error only error_report error >> message. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- > But in the client, I then perform 'w 0 0' (a zero-

Re: [Qemu-devel] [PATCH v4 RFC 9/8] nbd: Minimal structured read for client

2017-10-19 Thread Eric Blake
On 10/17/2017 07:57 AM, Vladimir Sementsov-Ogievskiy wrote: > Minimal implementation: for structured error only error_report error > message. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > +static int nbd_co_request(BlockDriverState *bs, NBDRequest *request, > +

Re: [Qemu-devel] [PATCH v4 RFC 9/8] nbd: Minimal structured read for client

2017-10-19 Thread Eric Blake
On 10/17/2017 07:57 AM, Vladimir Sementsov-Ogievskiy wrote: > Minimal implementation: for structured error only error_report error > message. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- and I replied: > > But in the client, I then perform 'w 0 0' (a zero-byte write, which > should fai

Re: [Qemu-devel] [PATCH v4 RFC 9/8] nbd: Minimal structured read for client

2017-10-17 Thread Eric Blake
On 10/17/2017 07:57 AM, Vladimir Sementsov-Ogievskiy wrote: > Minimal implementation: for structured error only error_report error > message. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > > RFC: I don't like resulting error handling: it is rather confusing, > requires a lot of

[Qemu-devel] [PATCH v4 RFC 9/8] nbd: Minimal structured read for client

2017-10-17 Thread Vladimir Sementsov-Ogievskiy
Minimal implementation: for structured error only error_report error message. Signed-off-by: Vladimir Sementsov-Ogievskiy --- it's an updated [PATCH v3 13/13] nbd: Minimal structured read for client https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg02760.html from [PATCH v3 00/13] nbd