Re: [Qemu-devel] [PATCH v4 5/8] spapr: Consolidate cpu init code into a routine

2015-06-17 Thread David Gibson
On Tue, Jun 16, 2015 at 08:36:34AM +0200, Thomas Huth wrote: > On Tue, 16 Jun 2015 15:40:05 +1000 > David Gibson wrote: > > > On Mon, Jun 15, 2015 at 10:15:09AM +0200, Thomas Huth wrote: > > > On Mon, 15 Jun 2015 16:59:08 +1000 > > > David Gibson wrote: > > > > > > > On Fri, Jun 05, 2015 at 09:

Re: [Qemu-devel] [PATCH v4 5/8] spapr: Consolidate cpu init code into a routine

2015-06-15 Thread Thomas Huth
On Tue, 16 Jun 2015 15:40:05 +1000 David Gibson wrote: > On Mon, Jun 15, 2015 at 10:15:09AM +0200, Thomas Huth wrote: > > On Mon, 15 Jun 2015 16:59:08 +1000 > > David Gibson wrote: > > > > > On Fri, Jun 05, 2015 at 09:55:55AM +0530, Bharata B Rao wrote: > > > > Factor out bits of sPAPR specific

Re: [Qemu-devel] [PATCH v4 5/8] spapr: Consolidate cpu init code into a routine

2015-06-15 Thread David Gibson
On Mon, Jun 15, 2015 at 10:15:09AM +0200, Thomas Huth wrote: > On Mon, 15 Jun 2015 16:59:08 +1000 > David Gibson wrote: > > > On Fri, Jun 05, 2015 at 09:55:55AM +0530, Bharata B Rao wrote: > > > Factor out bits of sPAPR specific CPU initialization code into > > > a separate routine so that it can

Re: [Qemu-devel] [PATCH v4 5/8] spapr: Consolidate cpu init code into a routine

2015-06-15 Thread Thomas Huth
On Mon, 15 Jun 2015 16:59:08 +1000 David Gibson wrote: > On Fri, Jun 05, 2015 at 09:55:55AM +0530, Bharata B Rao wrote: > > Factor out bits of sPAPR specific CPU initialization code into > > a separate routine so that it can be called from CPU hotplug > > path too. > > > > While at this, use MSR

Re: [Qemu-devel] [PATCH v4 5/8] spapr: Consolidate cpu init code into a routine

2015-06-15 Thread David Gibson
On Fri, Jun 05, 2015 at 09:55:55AM +0530, Bharata B Rao wrote: > Factor out bits of sPAPR specific CPU initialization code into > a separate routine so that it can be called from CPU hotplug > path too. > > While at this, use MSR_EP define instead of using 6 directly. Don't do this please. MSR[E

[Qemu-devel] [PATCH v4 5/8] spapr: Consolidate cpu init code into a routine

2015-06-04 Thread Bharata B Rao
Factor out bits of sPAPR specific CPU initialization code into a separate routine so that it can be called from CPU hotplug path too. While at this, use MSR_EP define instead of using 6 directly. Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c | 54 +-