Re: [Qemu-devel] [PATCH v4 5/8] block/mirror: fix and improve do_sync_target_write

2018-09-17 Thread John Snow
On 09/17/2018 10:57 AM, Vladimir Sementsov-Ogievskiy wrote: > Use bdrv_dirty_bitmap_next_dirty_area() instead of > bdrv_dirty_iter_next_area(), because of the following problems of > bdrv_dirty_iter_next_area(): > > 1. Using HBitmap iterators we should carefully handle unaligned offset, > as fi

[Qemu-devel] [PATCH v4 5/8] block/mirror: fix and improve do_sync_target_write

2018-09-17 Thread Vladimir Sementsov-Ogievskiy
Use bdrv_dirty_bitmap_next_dirty_area() instead of bdrv_dirty_iter_next_area(), because of the following problems of bdrv_dirty_iter_next_area(): 1. Using HBitmap iterators we should carefully handle unaligned offset, as first call to hbitmap_iter_next() may return a value less than original offse