Re: [Qemu-devel] [PATCH v4 5/7] blkdebug: Simplify override logic

2017-01-28 Thread Max Reitz
On 20.12.2016 20:15, Eric Blake wrote: > Rather than store into a local variable, then copy to the struct > if the value is valid, then reporting errors otherwise, it is > simpler to just store into the struct and report errors if the > value is invalid. This however requires that the struct store

[Qemu-devel] [PATCH v4 5/7] blkdebug: Simplify override logic

2016-12-20 Thread Eric Blake
Rather than store into a local variable, then copy to the struct if the value is valid, then reporting errors otherwise, it is simpler to just store into the struct and report errors if the value is invalid. This however requires that the struct store a 64-bit number, rather than a narrower type.