Re: [Qemu-devel] [PATCH v4 5/6] qapi: convert sendkey

2012-07-25 Thread Amos Kong
- Original Message - > On Wed, 25 Jul 2012 01:55:14 -0400 (EDT) > Amos Kong wrote: > > > > > > > - Original Message - > > > On Thu, 5 Jul 2012 20:48:44 +0800 > > > Amos Kong wrote: > > > > > > > Convert 'sendkey' to use QAPI. do_sendkey() depends on some > > > > variables/fun

Re: [Qemu-devel] [PATCH v4 5/6] qapi: convert sendkey

2012-07-25 Thread Luiz Capitulino
On Wed, 25 Jul 2012 01:55:14 -0400 (EDT) Amos Kong wrote: > > > - Original Message - > > On Thu, 5 Jul 2012 20:48:44 +0800 > > Amos Kong wrote: > > > > > Convert 'sendkey' to use QAPI. do_sendkey() depends on some > > > variables/functions in monitor.c, so reserve qmp_sendkey() > > >

Re: [Qemu-devel] [PATCH v4 5/6] qapi: convert sendkey

2012-07-24 Thread Amos Kong
- Original Message - > On Thu, 5 Jul 2012 20:48:44 +0800 > Amos Kong wrote: > > > Convert 'sendkey' to use QAPI. do_sendkey() depends on some > > variables/functions in monitor.c, so reserve qmp_sendkey() > > to monitor.c > > > > key_defs[] in console.h is the mapping of key name to k

Re: [Qemu-devel] [PATCH v4 5/6] qapi: convert sendkey

2012-07-18 Thread Amos Kong
- Original Message - > On Wed, 18 Jul 2012 20:56:54 +0800 > Amos Kong wrote: > > > >> +} KeyDef; > > >> + > > >> +static const KeyDef key_defs[] = { > > > > > > We can't have an array defined in a header file because it will > > > be defined in > > > each .c file that includes it. > > > >

Re: [Qemu-devel] [PATCH v4 5/6] qapi: convert sendkey

2012-07-18 Thread Luiz Capitulino
On Wed, 18 Jul 2012 20:56:54 +0800 Amos Kong wrote: > >> +} KeyDef; > >> + > >> +static const KeyDef key_defs[] = { > > > > We can't have an array defined in a header file because it will be defined > > in > > each .c file that includes it. > > > > Please, define it in input.c (along with qmp_se

Re: [Qemu-devel] [PATCH v4 5/6] qapi: convert sendkey

2012-07-18 Thread Amos Kong
On 12/07/12 23:09, Luiz Capitulino wrote: Hi Luiz, On Thu, 5 Jul 2012 20:48:44 +0800 Amos Kong wrote: Convert 'sendkey' to use QAPI. do_sendkey() depends on some variables/functions in monitor.c, so reserve qmp_sendkey() to monitor.c key_defs[] in console.h is the mapping of key name to

Re: [Qemu-devel] [PATCH v4 5/6] qapi: convert sendkey

2012-07-12 Thread Luiz Capitulino
On Thu, 5 Jul 2012 20:48:44 +0800 Amos Kong wrote: > Convert 'sendkey' to use QAPI. do_sendkey() depends on some > variables/functions in monitor.c, so reserve qmp_sendkey() > to monitor.c > > key_defs[] in console.h is the mapping of key name to keycode, > Keys' index in the enmu and key_defs[

[Qemu-devel] [PATCH v4 5/6] qapi: convert sendkey

2012-07-05 Thread Amos Kong
Convert 'sendkey' to use QAPI. do_sendkey() depends on some variables/functions in monitor.c, so reserve qmp_sendkey() to monitor.c key_defs[] in console.h is the mapping of key name to keycode, Keys' index in the enmu and key_defs[] is same. 'send-key' of QMP doesn't support key in hexadecimal f