Re: [Qemu-devel] [PATCH v4 4/9] hmp: disable monitor in preconfig state

2018-03-28 Thread Eduardo Habkost
On Wed, Mar 28, 2018 at 01:16:53PM +0200, Igor Mammedov wrote: > On Fri, 23 Mar 2018 18:27:32 -0300 > Eduardo Habkost wrote: > > > On Mon, Mar 12, 2018 at 02:11:10PM +0100, Igor Mammedov wrote: > > > Ban it for now, if someone would need it to work early, > > > one would have to implement checks

Re: [Qemu-devel] [PATCH v4 4/9] hmp: disable monitor in preconfig state

2018-03-28 Thread Igor Mammedov
On Fri, 23 Mar 2018 18:27:32 -0300 Eduardo Habkost wrote: > On Mon, Mar 12, 2018 at 02:11:10PM +0100, Igor Mammedov wrote: > > Ban it for now, if someone would need it to work early, > > one would have to implement checks if HMP command is valid > > at preconfig state. > > > > Signed-off-by: Igo

Re: [Qemu-devel] [PATCH v4 4/9] hmp: disable monitor in preconfig state

2018-03-23 Thread Eduardo Habkost
On Mon, Mar 12, 2018 at 02:11:10PM +0100, Igor Mammedov wrote: > Ban it for now, if someone would need it to work early, > one would have to implement checks if HMP command is valid > at preconfig state. > > Signed-off-by: Igor Mammedov > --- > v4: > * v3 was only printing error but not prevent

[Qemu-devel] [PATCH v4 4/9] hmp: disable monitor in preconfig state

2018-03-12 Thread Igor Mammedov
Ban it for now, if someone would need it to work early, one would have to implement checks if HMP command is valid at preconfig state. Signed-off-by: Igor Mammedov --- v4: * v3 was only printing error but not preventing command execution, Fix it by returning after printing error message.