Re: [Qemu-devel] [PATCH v4 4/7] qapi: Re-arrange monitor.c functions

2012-06-26 Thread Corey Bryant
On 06/26/2012 05:28 PM, Luiz Capitulino wrote: On Tue, 26 Jun 2012 17:16:28 -0400 Corey Bryant wrote: On 06/26/2012 04:45 PM, Luiz Capitulino wrote: On Fri, 22 Jun 2012 14:36:11 -0400 Corey Bryant wrote: Signed-off-by: Corey Bryant --- v4: -This patch is new in v4. Can you explai

Re: [Qemu-devel] [PATCH v4 4/7] qapi: Re-arrange monitor.c functions

2012-06-26 Thread Luiz Capitulino
On Tue, 26 Jun 2012 17:16:28 -0400 Corey Bryant wrote: > > > On 06/26/2012 04:45 PM, Luiz Capitulino wrote: > > On Fri, 22 Jun 2012 14:36:11 -0400 > > Corey Bryant wrote: > > > >> Signed-off-by: Corey Bryant > >> --- > >> v4: > >> -This patch is new in v4. > > > > Can you explain why it's n

Re: [Qemu-devel] [PATCH v4 4/7] qapi: Re-arrange monitor.c functions

2012-06-26 Thread Corey Bryant
On 06/26/2012 04:45 PM, Luiz Capitulino wrote: On Fri, 22 Jun 2012 14:36:11 -0400 Corey Bryant wrote: Signed-off-by: Corey Bryant --- v4: -This patch is new in v4. Can you explain why it's needed? This just made patch 3/7 easier to review. monitor.c | 40 --

Re: [Qemu-devel] [PATCH v4 4/7] qapi: Re-arrange monitor.c functions

2012-06-26 Thread Luiz Capitulino
On Fri, 22 Jun 2012 14:36:11 -0400 Corey Bryant wrote: > Signed-off-by: Corey Bryant > --- > v4: > -This patch is new in v4. Can you explain why it's needed? > > monitor.c | 40 > 1 file changed, 20 insertions(+), 20 deletions(-) > > diff --git a/

[Qemu-devel] [PATCH v4 4/7] qapi: Re-arrange monitor.c functions

2012-06-22 Thread Corey Bryant
Signed-off-by: Corey Bryant --- v4: -This patch is new in v4. monitor.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/monitor.c b/monitor.c index 3433c06..153e949 100644 --- a/monitor.c +++ b/monitor.c @@ -2239,26 +2239,6 @@ sta