Re: [Qemu-devel] [PATCH v4 4/6] vmdk: Check descriptor file length when reading it

2014-12-04 Thread Don Koch
On Thu, 4 Dec 2014 07:28:32 +0800 Fam Zheng wrote: > Since a too small file cannot be a valid VMDK image, and also since the > buffer's first 4 bytes will be unconditionally examined by > vmdk_open_sparse, let's error out the small file case to be clear. > > Signed-off-by: Fam Zheng > --- Revi

Re: [Qemu-devel] [PATCH v4 4/6] vmdk: Check descriptor file length when reading it

2014-12-04 Thread Markus Armbruster
Fam Zheng writes: > Since a too small file cannot be a valid VMDK image, and also since the > buffer's first 4 bytes will be unconditionally examined by > vmdk_open_sparse, let's error out the small file case to be clear. > > Signed-off-by: Fam Zheng Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v4 4/6] vmdk: Check descriptor file length when reading it

2014-12-04 Thread Max Reitz
On 2014-12-04 at 00:28, Fam Zheng wrote: Since a too small file cannot be a valid VMDK image, and also since the buffer's first 4 bytes will be unconditionally examined by vmdk_open_sparse, let's error out the small file case to be clear. Signed-off-by: Fam Zheng --- block/vmdk.c | 8

[Qemu-devel] [PATCH v4 4/6] vmdk: Check descriptor file length when reading it

2014-12-03 Thread Fam Zheng
Since a too small file cannot be a valid VMDK image, and also since the buffer's first 4 bytes will be unconditionally examined by vmdk_open_sparse, let's error out the small file case to be clear. Signed-off-by: Fam Zheng --- block/vmdk.c | 8 1 file changed, 8 insertions(+) diff --gi