Re: [Qemu-devel] [PATCH v4 4/6] qemu-img: Enable progress output for commit

2014-04-17 Thread Max Reitz
On 17.04.2014 14:08, Eric Blake wrote: On 04/17/2014 01:29 AM, Kevin Wolf wrote: Okay, now I have a better reason than "Meh, I don't like it" (which is always a very bad reason, of course), being the following: As mirror_run() is actually made for mirroring from an active block device, some sec

Re: [Qemu-devel] [PATCH v4 4/6] qemu-img: Enable progress output for commit

2014-04-17 Thread Eric Blake
On 04/17/2014 01:29 AM, Kevin Wolf wrote: >> Okay, now I have a better reason than "Meh, I don't like it" (which >> is always a very bad reason, of course), being the following: As >> mirror_run() is actually made for mirroring from an active block >> device, some sectors may be marked dirty durin

Re: [Qemu-devel] [PATCH v4 4/6] qemu-img: Enable progress output for commit

2014-04-17 Thread Fam Zheng
On Thu, 04/17 09:29, Kevin Wolf wrote: > Am 17.04.2014 um 00:53 hat Max Reitz geschrieben: > > On 16.04.2014 23:48, Max Reitz wrote: > > >On 16.04.2014 17:00, Kevin Wolf wrote: > > >>Am 12.04.2014 um 20:57 hat Max Reitz geschrieben: > > >>>Implement progress output for the commit command by queryin

Re: [Qemu-devel] [PATCH v4 4/6] qemu-img: Enable progress output for commit

2014-04-17 Thread Kevin Wolf
Am 17.04.2014 um 00:53 hat Max Reitz geschrieben: > On 16.04.2014 23:48, Max Reitz wrote: > >On 16.04.2014 17:00, Kevin Wolf wrote: > >>Am 12.04.2014 um 20:57 hat Max Reitz geschrieben: > >>>Implement progress output for the commit command by querying the > >>>progress of the block job. > >>> > >>>

Re: [Qemu-devel] [PATCH v4 4/6] qemu-img: Enable progress output for commit

2014-04-16 Thread Max Reitz
On 16.04.2014 23:48, Max Reitz wrote: On 16.04.2014 17:00, Kevin Wolf wrote: Am 12.04.2014 um 20:57 hat Max Reitz geschrieben: Implement progress output for the commit command by querying the progress of the block job. Signed-off-by: Max Reitz --- qemu-img-cmds.hx | 4 ++-- qemu-img.c

Re: [Qemu-devel] [PATCH v4 4/6] qemu-img: Enable progress output for commit

2014-04-16 Thread Max Reitz
On 16.04.2014 17:00, Kevin Wolf wrote: Am 12.04.2014 um 20:57 hat Max Reitz geschrieben: Implement progress output for the commit command by querying the progress of the block job. Signed-off-by: Max Reitz --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 44 +++

Re: [Qemu-devel] [PATCH v4 4/6] qemu-img: Enable progress output for commit

2014-04-16 Thread Kevin Wolf
Am 12.04.2014 um 20:57 hat Max Reitz geschrieben: > Implement progress output for the commit command by querying the > progress of the block job. > > Signed-off-by: Max Reitz > --- > qemu-img-cmds.hx | 4 ++-- > qemu-img.c | 44 ++-- > qemu-img.texi

[Qemu-devel] [PATCH v4 4/6] qemu-img: Enable progress output for commit

2014-04-12 Thread Max Reitz
Implement progress output for the commit command by querying the progress of the block job. Signed-off-by: Max Reitz --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 44 ++-- qemu-img.texi| 2 +- 3 files changed, 45 insertions(+), 5 deletions(-) di