Re: [Qemu-devel] [PATCH v4 4/5] target-i386: Move APIC ID compatibility code to pc.c

2015-03-06 Thread Eduardo Habkost
On Thu, Mar 05, 2015 at 04:47:53PM +0100, Andreas Färber wrote: > Am 05.03.2015 um 14:37 schrieb Eduardo Habkost: > > On Thu, Mar 05, 2015 at 01:32:02AM +0100, Andreas Färber wrote: > >> Am 04.03.2015 um 03:13 schrieb Eduardo Habkost: > >>> The APIC ID compatibility code is required only for PC, an

Re: [Qemu-devel] [PATCH v4 4/5] target-i386: Move APIC ID compatibility code to pc.c

2015-03-05 Thread Andreas Färber
Am 05.03.2015 um 14:37 schrieb Eduardo Habkost: > On Thu, Mar 05, 2015 at 01:32:02AM +0100, Andreas Färber wrote: >> Am 04.03.2015 um 03:13 schrieb Eduardo Habkost: >>> The APIC ID compatibility code is required only for PC, and now that >>> x86_cpu_initfn() doesn't use x86_cpu_apic_id_from_index()

Re: [Qemu-devel] [PATCH v4 4/5] target-i386: Move APIC ID compatibility code to pc.c

2015-03-05 Thread Eduardo Habkost
On Thu, Mar 05, 2015 at 01:32:02AM +0100, Andreas Färber wrote: > Am 04.03.2015 um 03:13 schrieb Eduardo Habkost: > > The APIC ID compatibility code is required only for PC, and now that > > x86_cpu_initfn() doesn't use x86_cpu_apic_id_from_index() anymore, that > > code can be moved to pc.c. > >

Re: [Qemu-devel] [PATCH v4 4/5] target-i386: Move APIC ID compatibility code to pc.c

2015-03-04 Thread Andreas Färber
Am 04.03.2015 um 03:13 schrieb Eduardo Habkost: > The APIC ID compatibility code is required only for PC, and now that > x86_cpu_initfn() doesn't use x86_cpu_apic_id_from_index() anymore, that > code can be moved to pc.c. > > Reviewed-by: Paolo Bonzini > Reviewed-by: Andreas Färber > Signed-off-

[Qemu-devel] [PATCH v4 4/5] target-i386: Move APIC ID compatibility code to pc.c

2015-03-03 Thread Eduardo Habkost
The APIC ID compatibility code is required only for PC, and now that x86_cpu_initfn() doesn't use x86_cpu_apic_id_from_index() anymore, that code can be moved to pc.c. Reviewed-by: Paolo Bonzini Reviewed-by: Andreas Färber Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 35 +