Re: [Qemu-devel] [PATCH v4 3/7] qapi: Add pass-fd QMP command

2012-06-25 Thread Corey Bryant
On 06/25/2012 11:34 AM, Kevin Wolf wrote: Am 25.06.2012 16:51, schrieb Corey Bryant: Thanks for catching this. I'll fix this in v5. In terms of platforms that support dup3 vs dup2, I'm assuming the following preprocessor checks will do what we need: #if defined(__linux__) || defined(__CYGWI

Re: [Qemu-devel] [PATCH v4 3/7] qapi: Add pass-fd QMP command

2012-06-25 Thread Eric Blake
On 06/25/2012 09:34 AM, Kevin Wolf wrote: > Am 25.06.2012 16:51, schrieb Corey Bryant: >> Thanks for catching this. I'll fix this in v5. In terms of platforms >> that support dup3 vs dup2, I'm assuming the following preprocessor >> checks will do what we need: >> >> #if defined(__linux__) || de

Re: [Qemu-devel] [PATCH v4 3/7] qapi: Add pass-fd QMP command

2012-06-25 Thread Kevin Wolf
Am 25.06.2012 16:51, schrieb Corey Bryant: > Thanks for catching this. I'll fix this in v5. In terms of platforms > that support dup3 vs dup2, I'm assuming the following preprocessor > checks will do what we need: > > #if defined(__linux__) || defined(__CYGWIN__) > dup3(fd, monfd->fd, O_CLOEXE

Re: [Qemu-devel] [PATCH v4 3/7] qapi: Add pass-fd QMP command

2012-06-25 Thread Corey Bryant
On 06/22/2012 04:24 PM, Eric Blake wrote: On 06/22/2012 12:36 PM, Corey Bryant wrote: This patch adds the pass-fd QMP command using the QAPI framework. Like the getfd command, it is used to pass a file descriptor via SCM_RIGHTS and associate it with a name. However, the pass-fd command also r

Re: [Qemu-devel] [PATCH v4 3/7] qapi: Add pass-fd QMP command

2012-06-22 Thread Eric Blake
On 06/22/2012 12:36 PM, Corey Bryant wrote: > This patch adds the pass-fd QMP command using the QAPI framework. > Like the getfd command, it is used to pass a file descriptor via > SCM_RIGHTS and associate it with a name. However, the pass-fd > command also returns the received file descriptor, wh

[Qemu-devel] [PATCH v4 3/7] qapi: Add pass-fd QMP command

2012-06-22 Thread Corey Bryant
This patch adds the pass-fd QMP command using the QAPI framework. Like the getfd command, it is used to pass a file descriptor via SCM_RIGHTS and associate it with a name. However, the pass-fd command also returns the received file descriptor, which is a difference in behavior from the getfd comma