Re: [Qemu-devel] [PATCH v4 3/4] target/arm: implement SM3 instructions

2018-01-22 Thread Ard Biesheuvel
On 22 January 2018 at 16:56, Peter Maydell wrote: > On 22 January 2018 at 16:52, Ard Biesheuvel wrote: >> On 22 January 2018 at 16:39, Peter Maydell wrote: >>> This seems to be missing support for SM4EKEY (which is O==1 >>> opcode == 0b10 and also part of the v8.2 SM feature) ? > >> It is part o

Re: [Qemu-devel] [PATCH v4 3/4] target/arm: implement SM3 instructions

2018-01-22 Thread Peter Maydell
On 22 January 2018 at 16:52, Ard Biesheuvel wrote: > On 22 January 2018 at 16:39, Peter Maydell wrote: >> This seems to be missing support for SM4EKEY (which is O==1 >> opcode == 0b10 and also part of the v8.2 SM feature) ? > It is part of the v8.2 SM extension, which consists of SM3 secure hash

Re: [Qemu-devel] [PATCH v4 3/4] target/arm: implement SM3 instructions

2018-01-22 Thread Ard Biesheuvel
On 22 January 2018 at 16:52, Ard Biesheuvel wrote: > On 22 January 2018 at 16:39, Peter Maydell wrote: >> On 19 January 2018 at 18:22, Ard Biesheuvel >> wrote: >>> This implements emulation of the new SM3 instructions that have >>> been added as an optional extension to the ARMv8 Crypto Extensi

Re: [Qemu-devel] [PATCH v4 3/4] target/arm: implement SM3 instructions

2018-01-22 Thread Ard Biesheuvel
On 22 January 2018 at 16:39, Peter Maydell wrote: > On 19 January 2018 at 18:22, Ard Biesheuvel wrote: >> This implements emulation of the new SM3 instructions that have >> been added as an optional extension to the ARMv8 Crypto Extensions >> in ARM v8.2. >> >> Signed-off-by: Ard Biesheuvel > >

Re: [Qemu-devel] [PATCH v4 3/4] target/arm: implement SM3 instructions

2018-01-22 Thread Peter Maydell
On 22 January 2018 at 16:39, Peter Maydell wrote: > This seems to be missing support for SM4EKEY (which is O==1 > opcode == 0b10 and also part of the v8.2 SM feature) ? Looks like SM4E (in the crypto-2-reg-sha512 decode section) is also missing. thanks -- PMM

Re: [Qemu-devel] [PATCH v4 3/4] target/arm: implement SM3 instructions

2018-01-22 Thread Peter Maydell
On 19 January 2018 at 18:22, Ard Biesheuvel wrote: > This implements emulation of the new SM3 instructions that have > been added as an optional extension to the ARMv8 Crypto Extensions > in ARM v8.2. > > Signed-off-by: Ard Biesheuvel > diff --git a/target/arm/translate-a64.c b/target/arm/trans

[Qemu-devel] [PATCH v4 3/4] target/arm: implement SM3 instructions

2018-01-19 Thread Ard Biesheuvel
This implements emulation of the new SM3 instructions that have been added as an optional extension to the ARMv8 Crypto Extensions in ARM v8.2. Signed-off-by: Ard Biesheuvel --- target/arm/cpu.h | 1 + target/arm/crypto_helper.c | 117 + target/arm/helper.h| 5 +