Re: [Qemu-devel] [PATCH v4 3/4] qmp: refactor duplicate code

2017-06-09 Thread Pradeep Jagadeesh
On 6/8/2017 4:20 PM, Greg Kurz wrote: On Fri, 12 May 2017 10:03:02 +0200 Pradeep Jagadeesh wrote: On 5/11/2017 9:50 AM, Greg Kurz wrote: On Wed, 10 May 2017 04:41:22 -0400 Pradeep Jagadeesh wrote: This patch factor out the duplicate qmp throttle interface code that was present in both bloc

Re: [Qemu-devel] [PATCH v4 3/4] qmp: refactor duplicate code

2017-06-08 Thread Greg Kurz
On Fri, 12 May 2017 10:03:02 +0200 Pradeep Jagadeesh wrote: > On 5/11/2017 9:50 AM, Greg Kurz wrote: > > On Wed, 10 May 2017 04:41:22 -0400 > > Pradeep Jagadeesh wrote: > > > >> This patch factor out the duplicate qmp throttle interface code > >> that was present in both block and fsdev device

Re: [Qemu-devel] [PATCH v4 3/4] qmp: refactor duplicate code

2017-05-12 Thread Pradeep Jagadeesh
On 5/11/2017 9:50 AM, Greg Kurz wrote: On Wed, 10 May 2017 04:41:22 -0400 Pradeep Jagadeesh wrote: This patch factor out the duplicate qmp throttle interface code that was present in both block and fsdev device files. There isn't any duplicated code at this stage since you have changed the

Re: [Qemu-devel] [PATCH v4 3/4] qmp: refactor duplicate code

2017-05-11 Thread Pradeep Jagadeesh
On 5/10/2017 9:56 PM, Eric Blake wrote: On 05/10/2017 03:41 AM, Pradeep Jagadeesh wrote: This patch factor out the duplicate qmp throttle interface code that was present in both block and fsdev device files. Signed-off-by: Pradeep Jagadeesh --- blockdev.c | 53 +++

Re: [Qemu-devel] [PATCH v4 3/4] qmp: refactor duplicate code

2017-05-11 Thread Greg Kurz
On Wed, 10 May 2017 04:41:22 -0400 Pradeep Jagadeesh wrote: > This patch factor out the duplicate qmp throttle interface code > that was present in both block and fsdev device files. > There isn't any duplicated code at this stage since you have changed the patch ordering. Also, this patch is

Re: [Qemu-devel] [PATCH v4 3/4] qmp: refactor duplicate code

2017-05-10 Thread Eric Blake
On 05/10/2017 03:41 AM, Pradeep Jagadeesh wrote: > This patch factor out the duplicate qmp throttle interface code > that was present in both block and fsdev device files. > > Signed-off-by: Pradeep Jagadeesh > --- > blockdev.c | 53 +++- >

[Qemu-devel] [PATCH v4 3/4] qmp: refactor duplicate code

2017-05-10 Thread Pradeep Jagadeesh
This patch factor out the duplicate qmp throttle interface code that was present in both block and fsdev device files. Signed-off-by: Pradeep Jagadeesh --- blockdev.c | 53 +++- hmp.c | 21 +++- includ