Re: [Qemu-devel] [PATCH v4 3/4] Fix address handling in inet_nonblocking_connect

2012-09-24 Thread Amos Kong
On 23/09/12 22:49, Orit Wasserman wrote: getaddrinfo can give us a list of addresses, but we only try to connect to the first one. If that fails we never proceed to the next one. This is common on desktop setups that often have ipv6 configured but not actually working. To fix this make inet_con

Re: [Qemu-devel] [PATCH v4 3/4] Fix address handling in inet_nonblocking_connect

2012-09-24 Thread Orit Wasserman
On 09/24/2012 12:05 PM, Amos Kong wrote: > On 23/09/12 22:49, Orit Wasserman wrote: >> getaddrinfo can give us a list of addresses, but we only try to >> connect to the first one. If that fails we never proceed to >> the next one. This is common on desktop setups that often have ipv6 >> configured

Re: [Qemu-devel] [PATCH v4 3/4] Fix address handling in inet_nonblocking_connect

2012-09-24 Thread Orit Wasserman
On 09/24/2012 12:10 PM, Michael S. Tsirkin wrote: > On Sun, Sep 23, 2012 at 04:49:06PM +0200, Orit Wasserman wrote: >> diff --git a/qemu_socket.h b/qemu_socket.h >> index 3247fb7..da93509 100644 >> --- a/qemu_socket.h >> +++ b/qemu_socket.h >> @@ -38,20 +38,31 @@ void socket_set_block(int fd); >>

Re: [Qemu-devel] [PATCH v4 3/4] Fix address handling in inet_nonblocking_connect

2012-09-24 Thread Markus Armbruster
Orit Wasserman writes: > getaddrinfo can give us a list of addresses, but we only try to > connect to the first one. If that fails we never proceed to > the next one. This is common on desktop setups that often have ipv6 > configured but not actually working. > > To fix this make inet_connect_no

[Qemu-devel] [PATCH v4 3/4] Fix address handling in inet_nonblocking_connect

2012-09-23 Thread Orit Wasserman
getaddrinfo can give us a list of addresses, but we only try to connect to the first one. If that fails we never proceed to the next one. This is common on desktop setups that often have ipv6 configured but not actually working. To fix this make inet_connect_nonblocking retry connection with a di