Re: [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests

2016-10-10 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Fri, Oct 7, 2016 at 10:16 PM Markus Armbruster wrote: > >> Marc-André Lureau writes: >> >> > These 2 tests exhibit two qmp bugs fixed by the previous patches. >> > >> > Signed-off-by: Marc-André Lureau >> > Reviewed-by: Daniel P. Berrange >> > Reviewed-by

Re: [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests

2016-10-10 Thread Marc-André Lureau
Hi On Fri, Oct 7, 2016 at 10:16 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > These 2 tests exhibit two qmp bugs fixed by the previous patches. > > > > Signed-off-by: Marc-André Lureau > > Reviewed-by: Daniel P. Berrange > > Reviewed-by: Eric Blake > > Fails make check, dropp

Re: [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests

2016-10-07 Thread Markus Armbruster
Marc-André Lureau writes: > These 2 tests exhibit two qmp bugs fixed by the previous patches. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Daniel P. Berrange > Reviewed-by: Eric Blake Fails make check, dropping from today's pull request.

Re: [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests

2016-10-06 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> Marc-André Lureau writes: >> >> > Hi >> > >> > - Original Message - >> > -snip- >> > >> >> >> >> I'd be willing to take this as is with a suitable TODO comment >> >> explaining where we want to go with this file. Perha

Re: [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests

2016-10-05 Thread Marc-André Lureau
Hi - Original Message - > Marc-André Lureau writes: > > > Hi > > > > - Original Message - > > -snip- > > > >> > >> I'd be willing to take this as is with a suitable TODO comment > >> explaining where we want to go with this file. Perhaps > >> > >> /* > >> * This program tests

Re: [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests

2016-10-05 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - > -snip- > >> >> I'd be willing to take this as is with a suitable TODO comment >> explaining where we want to go with this file. Perhaps >> >> /* >> * This program tests QMP commands that aren't interesting enough to >> * warra

Re: [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests

2016-10-05 Thread Marc-André Lureau
Hi - Original Message - -snip- > > I'd be willing to take this as is with a suitable TODO comment > explaining where we want to go with this file. Perhaps > > /* > * This program tests QMP commands that aren't interesting enough to > * warrant their own test program. > * > * TODO T

Re: [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests

2016-10-05 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> Marc-André Lureau writes: >> >> > These 2 tests exhibit two qmp bugs fixed by the previous patches. >> > >> > Signed-off-by: Marc-André Lureau >> > Reviewed-by: Daniel P. Berrange >> > Reviewed-by: Eric Blake >> > --- >> > t

Re: [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests

2016-10-05 Thread Marc-André Lureau
Hi - Original Message - > Marc-André Lureau writes: > > > These 2 tests exhibit two qmp bugs fixed by the previous patches. > > > > Signed-off-by: Marc-André Lureau > > Reviewed-by: Daniel P. Berrange > > Reviewed-by: Eric Blake > > --- > > tests/test-qemu-qmp.c | 69 > > ++

Re: [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests

2016-10-05 Thread Markus Armbruster
Marc-André Lureau writes: > These 2 tests exhibit two qmp bugs fixed by the previous patches. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Daniel P. Berrange > Reviewed-by: Eric Blake > --- > tests/test-qemu-qmp.c | 69 > ++ > tests/Mak

Re: [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests

2016-09-29 Thread Markus Armbruster
Marc-André Lureau writes: > These 2 tests exhibit two qmp bugs fixed by the previous patches. No objections to having QMP tests, but the ones fixed by PATCH 2 are QMP input visitor bugs, which sneaked through the existing test-qmp-input-visitor.c. Makes me suspect we should close the test cover

[Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests

2016-09-22 Thread Marc-André Lureau
These 2 tests exhibit two qmp bugs fixed by the previous patches. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrange Reviewed-by: Eric Blake --- tests/test-qemu-qmp.c | 69 ++ tests/Makefile.include | 2 ++ tests/.gitignore