Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls

2019-07-31 Thread P J P
+-- On Wed, 31 Jul 2019, Jason Wang wrote --+ | The series has been merged. Just need a patch on top and I can queue it for | next release. Sent patch v5. Thank you. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F

Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls

2019-07-31 Thread Jason Wang
On 2019/7/31 下午2:42, P J P wrote: +-- On Wed, 31 Jul 2019, Jason Wang wrote --+ | On 2019/7/29 下午11:04, Stefan Hajnoczi wrote: | > This change isn't related to the topic of the patch. It's a separate bug | > fix. | > | > Please either document it in the commit description so it's clear the | >

Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls

2019-07-30 Thread P J P
+-- On Wed, 31 Jul 2019, Jason Wang wrote --+ | On 2019/7/29 下午11:04, Stefan Hajnoczi wrote: | > This change isn't related to the topic of the patch. It's a separate bug | > fix. | > | > Please either document it in the commit description so it's clear the | > change is intentional, or send it a

Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls

2019-07-30 Thread Jason Wang
On 2019/7/29 下午11:04, Stefan Hajnoczi wrote: On Wed, Jul 24, 2019 at 11:18:09AM +0530, P J P wrote: +-- On Tue, 23 Jul 2019, Li Qiang wrote --+ | Stefan Hajnoczi 于2019年7月23日周二 下午9:03写道: | > On Tue, Jul 23, 2019 at 04:17:54PM +0530, P J P wrote: | > > -snprintf(helper_cmd, sizeof(h

Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls

2019-07-29 Thread Stefan Hajnoczi
On Wed, Jul 24, 2019 at 11:18:09AM +0530, P J P wrote: > +-- On Tue, 23 Jul 2019, Li Qiang wrote --+ > | Stefan Hajnoczi 于2019年7月23日周二 下午9:03写道: > | > On Tue, Jul 23, 2019 at 04:17:54PM +0530, P J P wrote: > | > > -snprintf(helper_cmd, sizeof(helper_cmd), "%s %s %s %s", > | > > -

Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls

2019-07-23 Thread P J P
+-- On Tue, 23 Jul 2019, Li Qiang wrote --+ | Stefan Hajnoczi 于2019年7月23日周二 下午9:03写道: | > On Tue, Jul 23, 2019 at 04:17:54PM +0530, P J P wrote: | > > -snprintf(helper_cmd, sizeof(helper_cmd), "%s %s %s %s", | > > - helper, "--use-vnet", fd_buf, br_buf); | > > +

Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls

2019-07-23 Thread Li Qiang
Stefan Hajnoczi 于2019年7月23日周二 下午9:03写道: > On Tue, Jul 23, 2019 at 04:17:54PM +0530, P J P wrote: > > -snprintf(helper_cmd, sizeof(helper_cmd), "%s %s %s %s", > > - helper, "--use-vnet", fd_buf, br_buf); > > +helper_cmd = g_strdup_printf("%s %s %s %s", h

Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls

2019-07-23 Thread Daniel P . Berrangé
On Tue, Jul 23, 2019 at 04:17:54PM +0530, P J P wrote: > From: Prasad J Pandit > > When invoking qemu-bridge-helper in 'net_bridge_run_helper', > instead of using fixed sized buffers, use dynamically allocated > ones initialised and returned by g_strdup_printf(). > > Signed-off-by: Prasad J Pand

Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls

2019-07-23 Thread Stefan Hajnoczi
On Tue, Jul 23, 2019 at 04:17:54PM +0530, P J P wrote: > -snprintf(helper_cmd, sizeof(helper_cmd), "%s %s %s %s", > - helper, "--use-vnet", fd_buf, br_buf); > +helper_cmd = g_strdup_printf("%s %s %s %s", helper, > +"--use-vnet"

[Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls

2019-07-23 Thread P J P
From: Prasad J Pandit When invoking qemu-bridge-helper in 'net_bridge_run_helper', instead of using fixed sized buffers, use dynamically allocated ones initialised and returned by g_strdup_printf(). Signed-off-by: Prasad J Pandit --- net/tap.c | 19 +++ 1 file changed, 11 inser