Re: [Qemu-devel] [PATCH v4 3/3] arm: Add BBC micro:bit machine

2018-08-25 Thread Joel Stanley
On Thu, 16 Aug 2018 at 07:12, Peter Maydell wrote: > > +static void microbit_machine_init(MachineClass *mc) > > +{ > > +mc->desc = "BBC micro:bit"; > > +mc->init = microbit_init; > > +mc->max_cpus = 1; > > +} > > +DEFINE_MACHINE("microbit", microbit_machine_init); > > Your subclass of

Re: [Qemu-devel] [PATCH v4 3/3] arm: Add BBC micro:bit machine

2018-08-16 Thread Steffen Görtz
>> + >> +arm_m_profile_load_kernel(ARM_CPU(first_cpu), machine->kernel_filename, >> +NRF51_SOC(soc)->flash_size); >> +} >> + >> +static void microbit_machine_init(MachineClass *mc) >> +{ >> +mc->desc = "BBC micro:bit"; >> +mc->init = microbit_init; >> +mc->max_cpus = 1

Re: [Qemu-devel] [PATCH v4 3/3] arm: Add BBC micro:bit machine

2018-08-16 Thread Peter Maydell
On 16 August 2018 at 15:19, Steffen Görtz wrote: > >>> + >>> +arm_m_profile_load_kernel(ARM_CPU(first_cpu), machine->kernel_filename, >>> +NRF51_SOC(soc)->flash_size); >>> +} >>> + >>> +static void microbit_machine_init(MachineClass *mc) >>> +{ >>> +mc->desc = "BBC micro:bit";

Re: [Qemu-devel] [PATCH v4 3/3] arm: Add BBC micro:bit machine

2018-08-16 Thread Peter Maydell
On 3 August 2018 at 06:21, Joel Stanley wrote: > This adds the base for a machine model of the BBC micro:bit: > > https://en.wikipedia.org/wiki/Micro_Bit > > This is a system with a nRF51 SoC containing the main processor, with > various peripherals on board. > > Reviewed-by: Stefan Hajnoczi >

[Qemu-devel] [PATCH v4 3/3] arm: Add BBC micro:bit machine

2018-08-02 Thread Joel Stanley
This adds the base for a machine model of the BBC micro:bit: https://en.wikipedia.org/wiki/Micro_Bit This is a system with a nRF51 SoC containing the main processor, with various peripherals on board. Reviewed-by: Stefan Hajnoczi Signed-off-by: Joel Stanley --- v2: - Instead of setting kern