On Tue, Aug 09, 2011 at 03:44:35PM +0300, Avi Kivity wrote:
> On 08/09/2011 03:42 PM, Michael S. Tsirkin wrote:
> >On Tue, Aug 09, 2011 at 09:52:17AM +0300, Avi Kivity wrote:
> >> On 08/09/2011 09:55 AM, Bob Breuer wrote:
> >> >>static void lance_cleanup(VLANClientState *nc)
> >> >> @@ -11
On 08/09/2011 03:42 PM, Michael S. Tsirkin wrote:
On Tue, Aug 09, 2011 at 09:52:17AM +0300, Avi Kivity wrote:
> On 08/09/2011 09:55 AM, Bob Breuer wrote:
> >>static void lance_cleanup(VLANClientState *nc)
> >> @@ -117,13 +116,11 @@ static int lance_init(SysBusDevice *dev)
> >>Sy
On Tue, Aug 09, 2011 at 09:52:17AM +0300, Avi Kivity wrote:
> On 08/09/2011 09:55 AM, Bob Breuer wrote:
> >> static void lance_cleanup(VLANClientState *nc)
> >> @@ -117,13 +116,11 @@ static int lance_init(SysBusDevice *dev)
> >> SysBusPCNetState *d = FROM_SYSBUS(SysBusPCNetState, dev);
> >
On 08/09/2011 03:48 PM, Michael S. Tsirkin wrote:
>
> But in some cases, we can't, and the it's a pain having to wrap
> MemoryRegion in another structure containing an opaque.
I guess, even though that wrapping structure would
use a proper type, not an opaque.
Yes, of course - that's what th
On 08/09/2011 09:55 AM, Bob Breuer wrote:
> static void lance_cleanup(VLANClientState *nc)
> @@ -117,13 +116,11 @@ static int lance_init(SysBusDevice *dev)
> SysBusPCNetState *d = FROM_SYSBUS(SysBusPCNetState, dev);
> PCNetState *s =&d->state;
>
> -s->mmio_index =
> -
Avi Kivity wrote:
> Also related chips.
>
> Reviewed-by: Richard Henderson
> Reviewed-by: Anthony Liguori
> Signed-off-by: Avi Kivity
> ---
> hw/lance.c | 31 ++-
> hw/pcnet-pci.c | 74 +--
> hw/pcnet.h |4
Also related chips.
Reviewed-by: Richard Henderson
Reviewed-by: Anthony Liguori
Signed-off-by: Avi Kivity
---
hw/lance.c | 31 ++-
hw/pcnet-pci.c | 74 +--
hw/pcnet.h |4 ++-
3 files changed, 61 insertions(
