Re: [Qemu-devel] [PATCH v4 25/28] qapi: Support pretty printing in JSON output visitor

2016-06-03 Thread Markus Armbruster
Eric Blake writes: > On 06/03/2016 01:56 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Similar to pretty printing in the QObject visitor. The trickiest >>> part is probably that the testsuite now has to honor parameterization >>> on whether pretty printing is enabled. >> >> Worth

Re: [Qemu-devel] [PATCH v4 25/28] qapi: Support pretty printing in JSON output visitor

2016-06-03 Thread Eric Blake
On 06/03/2016 01:56 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Similar to pretty printing in the QObject visitor. The trickiest >> part is probably that the testsuite now has to honor parameterization >> on whether pretty printing is enabled. > > Worth mentioning that the pretty-pri

Re: [Qemu-devel] [PATCH v4 25/28] qapi: Support pretty printing in JSON output visitor

2016-06-03 Thread Markus Armbruster
Eric Blake writes: > Similar to pretty printing in the QObject visitor. The trickiest > part is probably that the testsuite now has to honor parameterization > on whether pretty printing is enabled. Worth mentioning that the pretty-printing matches the one in qobject-json.c? > > Signed-off-by:

[Qemu-devel] [PATCH v4 25/28] qapi: Support pretty printing in JSON output visitor

2016-05-18 Thread Eric Blake
Similar to pretty printing in the QObject visitor. The trickiest part is probably that the testsuite now has to honor parameterization on whether pretty printing is enabled. Signed-off-by: Eric Blake --- v4: rebase to earlier changes, defer type_any() to later v3: rebase to earlier changes v2: