Re: [Qemu-devel] [PATCH v4 20/29] util: add qemu_write_pidfile()

2018-08-31 Thread Daniel P . Berrangé
On Fri, Jul 13, 2018 at 03:09:07PM +0200, Marc-André Lureau wrote: > There are variants of qemu_create_pidfile() in qemu-pr-helper and > qemu-ga. Let's have a common implementation in libqemuutil. > > The code is based from pr-helper write_pidfile(), but allows the > caller to deal with error repo

Re: [Qemu-devel] [PATCH v4 20/29] util: add qemu_write_pidfile()

2018-08-28 Thread Marc-André Lureau
Hi On Tue, Aug 28, 2018 at 5:53 PM Daniel P. Berrangé wrote: > > On Fri, Jul 13, 2018 at 03:09:07PM +0200, Marc-André Lureau wrote: > > There are variants of qemu_create_pidfile() in qemu-pr-helper and > > qemu-ga. Let's have a common implementation in libqemuutil. > > > > The code is based from p

Re: [Qemu-devel] [PATCH v4 20/29] util: add qemu_write_pidfile()

2018-08-28 Thread Daniel P . Berrangé
On Fri, Jul 13, 2018 at 03:09:07PM +0200, Marc-André Lureau wrote: > There are variants of qemu_create_pidfile() in qemu-pr-helper and > qemu-ga. Let's have a common implementation in libqemuutil. > > The code is based from pr-helper write_pidfile(), but allows the > caller to deal with error repo

[Qemu-devel] [PATCH v4 20/29] util: add qemu_write_pidfile()

2018-07-13 Thread Marc-André Lureau
There are variants of qemu_create_pidfile() in qemu-pr-helper and qemu-ga. Let's have a common implementation in libqemuutil. The code is based from pr-helper write_pidfile(), but allows the caller to deal with error reporting and behaviour. Signed-off-by: Marc-André Lureau --- include/qemu/osd