Re: [Qemu-devel] [PATCH v4 2/8] pc: move igd support code to igd.c

2016-03-10 Thread Kay, Allen M
> -Original Message- > From: Tian, Kevin > Sent: Wednesday, March 09, 2016 9:56 PM > To: Gerd Hoffmann > Cc: Alex Williamson ; Stefano Stabellini > ; xen-de...@lists.xensource.com; igvt- > g...@ml01.01.org; Michael S. Tsirkin ; open list:All patches > CC here ; Kay, Allen M > Subject: R

Re: [Qemu-devel] [PATCH v4 2/8] pc: move igd support code to igd.c

2016-03-09 Thread Tian, Kevin
> From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Wednesday, March 09, 2016 11:08 PM > > Hi, > > > +/* Here we just expose minimal host bridge offset subset. */ > > +static const IGDHostInfo igd_host_bridge_infos[] = { > > +{0x08, 2}, /* revision id */ > > +{0x2c, 2}, /* sybsys

Re: [Qemu-devel] [PATCH v4 2/8] pc: move igd support code to igd.c

2016-03-09 Thread Gerd Hoffmann
Hi, > +/* Here we just expose minimal host bridge offset subset. */ > +static const IGDHostInfo igd_host_bridge_infos[] = { > +{0x08, 2}, /* revision id */ > +{0x2c, 2}, /* sybsystem vendor id */ > +{0x2e, 2}, /* sybsystem id */ Can anyone clarify where this comes from? Setting

[Qemu-devel] [PATCH v4 2/8] pc: move igd support code to igd.c

2016-03-08 Thread Gerd Hoffmann
Pure code motion, except for dropping instance_size for TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE (no need to set, we can inherit it from TYPE_I440FX_PCI_DEVICE). Signed-off-by: Gerd Hoffmann Acked-by: Stefano Stabellini --- default-configs/x86_64-softmmu.mak | 1 + hw/pci-host/Makefile.objs