Re: [Qemu-devel] [PATCH v4 2/8] apic: add send_msi() to APICCommonClass

2016-10-10 Thread Peter Xu
On Mon, Oct 10, 2016 at 03:35:26PM +0200, Radim Krčmář wrote: [...] > Yes, but it is a separate logical change, so I'd do that in a separate > cleaup patch that amends it in the whole file ... > (And I prefer to copy-paste code verbatim.) Sure. > > > And, this patch is assuming MSIMessage as h

Re: [Qemu-devel] [PATCH v4 2/8] apic: add send_msi() to APICCommonClass

2016-10-10 Thread Radim Krčmář
2016-10-08 14:37+0800, Peter Xu: > On Wed, Oct 05, 2016 at 03:06:51PM +0200, Radim Krčmář wrote: >> The MMIO based interface to APIC doesn't work well with MSIs that have >> upper address bits set (remapped x2APIC MSIs). A specialized interface >> is a quick and dirty way to avoid the shortcoming.

Re: [Qemu-devel] [PATCH v4 2/8] apic: add send_msi() to APICCommonClass

2016-10-09 Thread Michael S. Tsirkin
On Sat, Oct 08, 2016 at 02:37:59PM +0800, Peter Xu wrote: > On Wed, Oct 05, 2016 at 03:06:51PM +0200, Radim Krčmář wrote: > > The MMIO based interface to APIC doesn't work well with MSIs that have > > upper address bits set (remapped x2APIC MSIs). A specialized interface > > is a quick and dirty w

Re: [Qemu-devel] [PATCH v4 2/8] apic: add send_msi() to APICCommonClass

2016-10-07 Thread Peter Xu
On Wed, Oct 05, 2016 at 03:06:51PM +0200, Radim Krčmář wrote: > The MMIO based interface to APIC doesn't work well with MSIs that have > upper address bits set (remapped x2APIC MSIs). A specialized interface > is a quick and dirty way to avoid the shortcoming. > > Reviewed-by: Igor Mammedov > Si

[Qemu-devel] [PATCH v4 2/8] apic: add send_msi() to APICCommonClass

2016-10-05 Thread Radim Krčmář
The MMIO based interface to APIC doesn't work well with MSIs that have upper address bits set (remapped x2APIC MSIs). A specialized interface is a quick and dirty way to avoid the shortcoming. Reviewed-by: Igor Mammedov Signed-off-by: Radim Krčmář --- v4: r-b Igor v2: change apic_send_msi() to