Re: [Qemu-devel] [PATCH v4 2/5] target-i386: Remove unused APIC ID default code

2015-03-06 Thread Eduardo Habkost
On Thu, Mar 05, 2015 at 03:46:13PM -0300, Eduardo Habkost wrote: > On Thu, Mar 05, 2015 at 07:35:17PM +0100, Andreas Färber wrote: > > Am 05.03.2015 um 14:43 schrieb Eduardo Habkost: > > > On Tue, Mar 03, 2015 at 11:13:41PM -0300, Eduardo Habkost wrote: > > >> The existing apic_id = cpu_index code

Re: [Qemu-devel] [PATCH v4 2/5] target-i386: Remove unused APIC ID default code

2015-03-05 Thread Eduardo Habkost
On Thu, Mar 05, 2015 at 07:35:17PM +0100, Andreas Färber wrote: > Am 05.03.2015 um 14:43 schrieb Eduardo Habkost: > > On Tue, Mar 03, 2015 at 11:13:41PM -0300, Eduardo Habkost wrote: > >> The existing apic_id = cpu_index code has no visible effect: the PC code > >> already initializes the APIC ID a

Re: [Qemu-devel] [PATCH v4 2/5] target-i386: Remove unused APIC ID default code

2015-03-05 Thread Andreas Färber
Am 05.03.2015 um 14:43 schrieb Eduardo Habkost: > On Tue, Mar 03, 2015 at 11:13:41PM -0300, Eduardo Habkost wrote: >> The existing apic_id = cpu_index code has no visible effect: the PC code >> already initializes the APIC ID according to the topology on >> pc_new_cpu(), and linux-user memcpy()s th

Re: [Qemu-devel] [PATCH v4 2/5] target-i386: Remove unused APIC ID default code

2015-03-05 Thread Paolo Bonzini
On 05/03/2015 14:43, Eduardo Habkost wrote: > On Tue, Mar 03, 2015 at 11:13:41PM -0300, Eduardo Habkost wrote: >> The existing apic_id = cpu_index code has no visible effect: the PC code >> already initializes the APIC ID according to the topology on >> pc_new_cpu(), and linux-user memcpy()s the

Re: [Qemu-devel] [PATCH v4 2/5] target-i386: Remove unused APIC ID default code

2015-03-05 Thread Eduardo Habkost
On Tue, Mar 03, 2015 at 11:13:41PM -0300, Eduardo Habkost wrote: > The existing apic_id = cpu_index code has no visible effect: the PC code > already initializes the APIC ID according to the topology on > pc_new_cpu(), and linux-user memcpy()s the CPU state (including > cpuid_apic_id) on cpu_copy()

[Qemu-devel] [PATCH v4 2/5] target-i386: Remove unused APIC ID default code

2015-03-03 Thread Eduardo Habkost
The existing apic_id = cpu_index code has no visible effect: the PC code already initializes the APIC ID according to the topology on pc_new_cpu(), and linux-user memcpy()s the CPU state (including cpuid_apic_id) on cpu_copy(). Remove the dead code and simply let APIC ID to to be 0 by default. Thi