Re: [Qemu-devel] [PATCH v4 2/3] target/s390x: exception on non-aligned LPSW(E)

2018-08-22 Thread Richard Henderson
On 08/22/2018 07:40 AM, Pavel Zbitskiy wrote: > @@ -2828,9 +2828,13 @@ static DisasJumpType op_lpp(DisasContext *s, DisasOps > *o) > > static DisasJumpType op_lpsw(DisasContext *s, DisasOps *o) > { > +TCGv_i32 t0; > TCGv_i64 t1, t2; > > check_privileged(s); > +t0 = tcg_cons

Re: [Qemu-devel] [PATCH v4 2/3] target/s390x: exception on non-aligned LPSW(E)

2018-08-22 Thread David Hildenbrand
On 22.08.2018 16:40, Pavel Zbitskiy wrote: > Both LPSW and LPSWE should raise a specification exception when their > operand is not doubleword aligned. > > This could've been done without a helper, but this would introduce a > new basic block, which would require making o->in2 local. This > could'

[Qemu-devel] [PATCH v4 2/3] target/s390x: exception on non-aligned LPSW(E)

2018-08-22 Thread Pavel Zbitskiy
Both LPSW and LPSWE should raise a specification exception when their operand is not doubleword aligned. This could've been done without a helper, but this would introduce a new basic block, which would require making o->in2 local. This could've also been done in load_psw helper, but this is too l