Re: [Qemu-devel] [PATCH v4 2/3] arm: qmp: add query-gic-capabilities interface

2016-03-19 Thread Peter Xu
On Wed, Mar 16, 2016 at 10:24:39AM +, Peter Maydell wrote: > On 8 March 2016 at 07:36, Peter Xu wrote: > > diff --git a/target-arm/machine.c b/target-arm/machine.c > > index 03a73d9..813909e 100644 > > --- a/target-arm/machine.c > > +++ b/target-arm/machine.c > > @@ -5,6 +5,7 @@ > > #include

Re: [Qemu-devel] [PATCH v4 2/3] arm: qmp: add query-gic-capabilities interface

2016-03-19 Thread Peter Maydell
On 17 March 2016 at 04:09, Peter Xu wrote: > Thanks for the review comments. Do you have any suggestion on which > file should I add this in (or create a new one)? I failed to figure > it out myself. :( I suggest target-arm/monitor.c (we have a monitor.c for other target-* already for monitor rel

Re: [Qemu-devel] [PATCH v4 2/3] arm: qmp: add query-gic-capabilities interface

2016-03-19 Thread Peter Xu
On Thu, Mar 17, 2016 at 08:50:38AM +, Peter Maydell wrote: > On 17 March 2016 at 04:09, Peter Xu wrote: > > Thanks for the review comments. Do you have any suggestion on which > > file should I add this in (or create a new one)? I failed to figure > > it out myself. :( > > I suggest target-ar

Re: [Qemu-devel] [PATCH v4 2/3] arm: qmp: add query-gic-capabilities interface

2016-03-16 Thread Peter Maydell
On 8 March 2016 at 07:36, Peter Xu wrote: > This patch adds the command "query-gic-capabilities" but not implemnet > it. The command is ARM-only. Return of the command is a list of > GICCapability struct that describes all GIC versions that current QEMU > and system support. > > Signed-off-by: Pet

[Qemu-devel] [PATCH v4 2/3] arm: qmp: add query-gic-capabilities interface

2016-03-07 Thread Peter Xu
This patch adds the command "query-gic-capabilities" but not implemnet it. The command is ARM-only. Return of the command is a list of GICCapability struct that describes all GIC versions that current QEMU and system support. Signed-off-by: Peter Xu --- monitor.c| 8 qapi-s