Re: [Qemu-devel] [PATCH v4 2/3] Simpletrace v2: Support multiple arguments, strings.

2012-06-13 Thread Stefan Hajnoczi
On Tue, Jun 12, 2012 at 4:16 PM, Harsh Prateek Bora wrote: > +int trace_alloc_record(TraceBufferRecord *rec, TraceEventID event, uint32_t > datasize); This should be static. > +static void read_from_buffer(unsigned int idx, void *dataptr, size_t size); > +static unsigned int write_to_buffer(uns

[Qemu-devel] [PATCH v4 2/3] Simpletrace v2: Support multiple arguments, strings.

2012-06-12 Thread Harsh Prateek Bora
Existing simpletrace backend allows to trace at max 6 args and does not support strings. This newer tracelog format gets rid of fixed size records and therefore allows to trace variable number of args including strings. Sample trace with strings: v9fs_version 0.000 tag=0x id=0x64 msize=0x2000