Re: [Qemu-devel] [PATCH v4 2/2] trace: Avoid implicit bool->integer conversions

2016-08-18 Thread Daniel P. Berrange
On Fri, Aug 12, 2016 at 05:33:46PM +0200, Lluís Vilanova wrote: > An explicit if/else is clearer than arithmetic assuming #true is 1, > while the compiler should be able to generate just as optimal code. > > Signed-off-by: Lluís Vilanova > --- > stubs/trace-control.c | 17 +++-- >

[Qemu-devel] [PATCH v4 2/2] trace: Avoid implicit bool->integer conversions

2016-08-12 Thread Lluís Vilanova
An explicit if/else is clearer than arithmetic assuming #true is 1, while the compiler should be able to generate just as optimal code. Signed-off-by: Lluís Vilanova --- stubs/trace-control.c | 17 +++-- trace/control-target.c | 31 ++- 2 files change