Re: [Qemu-devel] [PATCH v4 2/2] qga: Add guest-get-fsinfo command

2014-06-20 Thread Tomoki Sekiyama
On 6/20/14 11:21 , "Eric Blake" wrote: >On 06/19/2014 06:34 PM, Tomoki Sekiyama wrote: > +} +if (S_ISBLK(st.st_mode)) { +*devmajor = major(st.st_rdev); +*devminor = minor(st.st_rdev); >>> >>> major() and minor() are not POSIX functions. While they work

Re: [Qemu-devel] [PATCH v4 2/2] qga: Add guest-get-fsinfo command

2014-06-20 Thread Eric Blake
On 06/19/2014 06:34 PM, Tomoki Sekiyama wrote: >>> +} >>> +if (S_ISBLK(st.st_mode)) { >>> +*devmajor = major(st.st_rdev); >>> +*devminor = minor(st.st_rdev); >> >> major() and minor() are not POSIX functions. While they work on Linux, >> and appear to have BSD origins, I s

Re: [Qemu-devel] [PATCH v4 2/2] qga: Add guest-get-fsinfo command

2014-06-19 Thread Tomoki Sekiyama
Hi Eric, Thank you for the review. On 6/19/14 17:23 , "Eric Blake" wrote: >On 06/05/2014 08:57 AM, Tomoki Sekiyama wrote: >> Add command to get mounted filesystems information in the guest. >> The returned value contains a list of mountpoint paths and >> corresponding disks info such as disk bu

Re: [Qemu-devel] [PATCH v4 2/2] qga: Add guest-get-fsinfo command

2014-06-19 Thread Eric Blake
On 06/05/2014 08:57 AM, Tomoki Sekiyama wrote: > Add command to get mounted filesystems information in the guest. > The returned value contains a list of mountpoint paths and > corresponding disks info such as disk bus type, drive address, > and the disk controllers' PCI addresses, so that manageme

[Qemu-devel] [PATCH v4 2/2] qga: Add guest-get-fsinfo command

2014-06-05 Thread Tomoki Sekiyama
Add command to get mounted filesystems information in the guest. The returned value contains a list of mountpoint paths and corresponding disks info such as disk bus type, drive address, and the disk controllers' PCI addresses, so that management layer such as libvirt can resolve the disk backends.